Skip to content

docs(rum/flutter): correct integration drift and document missing capabilities - #211

Closed
Fiona2016 wants to merge 1 commit into
mainfrom
doc-review/2026-07-27-052848-flutter-sdk
Closed

docs(rum/flutter): correct integration drift and document missing capabilities#211
Fiona2016 wants to merge 1 commit into
mainfrom
doc-review/2026-07-27-052848-flutter-sdk

Conversation

@Fiona2016

Copy link
Copy Markdown
Contributor

Doc Review — 2026-07-27

Mode: audit
Scope: rum/sdk/flutter
Source ref: fc-sdk-flutter @ origin/main
Findings: 13 total — 5 high, 5 medium, 3 low (all applied)

Changes

Finding Type Doc Action
f001 stale_content sdk-integration, compatible Replaced the git-source install with hosted pub.dev deps; dropped the "publication pending" note
f002 feature_drift sdk-integration Replaced the non-compiling setUserInfo() logout snippet with clearUserInfo()
f003 config_drift sdk-integration, compatible Corrected Flutter/Dart/iOS/Android minimums; added the Kotlin and native-SDK versions
f004 missing_coverage sdk-integration, compatible Added a WebView tracking section (trackDatadogEvents, allowed hosts, Android caveat)
f005 stale_content sdk-integration, compatible Rewrote network collection around flashcat_tracking_http_client; added DatadogClient and the HttpOverrides.global caveat
f006 config_drift sdk-integration, compatible Bumped the documented version 0.1.0 → 0.1.1
f007 missing_coverage advanced-config Documented vitalUpdateFrequency, reportFlutterPerformance, initialResourceThreshold, trackNonFatalAnrs, appHangThreshold, traceContextInjection
f008 missing_coverage sdk-integration, data-collection Documented account APIs, addUserExtraInfo, clearAllData, attachToBackgroundIsolate
f009 missing_coverage advanced-config Added an application version / service section incl. the +- tag normalization
f010 missing_coverage advanced-config Documented firstPartyHostsWithTracingHeaders and the TracingHeaderType values
f011 config_drift compatible Renamed datadog_tracking_http_clientflashcat_tracking_http_client; dropped the dependency_overrides caveat
f012 config_drift compatible Clarified that site is a required parameter
f013 missing_coverage advanced-config Documented the BatchSize / UploadFrequency / BatchProcessingLevel enum values

8 files changed (zh + en × 4 pages), +581 / −155. No new pages, so docs.json is unchanged. mint broken-links passes.

The three highest-impact fixes

  1. Install instructions were unusable. The docs told users to depend on a git URL and said pub.dev publication was still being confirmed. All three packages have been live on pub.dev under the flashcat.cloud verified publisher since 2026-07-06.
  2. A documented snippet did not compile. DatadogSdk.instance.setUserInfo() was given as the logout call, but id is a required named parameter. The real API is clearUserInfo().
  3. Documented platform minimums were below the real ones. A project built to the documented Flutter 3.0 / Dart 3.0 / iOS 12.0 / minSdkVersion 21 would fail to build against Flutter 3.27 / Dart 3.6 / iOS 13.0 / minSdkVersion 23.

Review checklist

  • Verify config field names and defaults match current code
  • Check that feature descriptions accurately reflect user-facing behavior
  • Ensure tone and style match the rest of the docs

Notes for follow-up (outside this PR)

  • Podspec vs README disagree on the iOS minimum. packages/datadog_flutter_plugin/ios/flashcat_flutter_plugin.podspec declares s.platform = :ios, '12.0', while the plugin README and the pub.dev listing both say 13.0. The docs now state 13.0 (the stricter, user-facing number). Worth reconciling in fc-sdk-flutter.
  • The plugin README is itself stale. Its "Not yet available" list still names automatic HTTP/resource tracking, but flashcat_tracking_http_client was ported in 2da34728, after the README alignment commit 0bb5df35.
  • origin/HEAD for fc-sdk-flutter points at develop, which tracks upstream DataDog code (packages still named datadog_* at 3.4.0, commits authored by Datadog engineers). Any tooling that auto-detects the default branch for this repo will analyze the wrong tree — this audit pinned origin/main deliberately.
  • No performance-impact.mdx was created. web / android / ios have one; flutter and harmony do not. fc-sdk-flutter contains no benchmark data, and writing the page would have meant inventing numbers. It needs real measurements from a human.
  • Two feature branches dated today (origin/feat/rum-app-launch, origin/feat/refresh-rate-on-publish) add app-launch and refresh-rate metrics. They are not merged to main and are excluded from this pass.

🤖 Generated with Claude Code

…abilities

Audited zh/en Flutter SDK docs against fc-sdk-flutter origin/main (the
FlashCat-branded release branch; origin/HEAD points at develop, which
tracks upstream DataDog code).

Corrections:
- Install from pub.dev instead of a git source. flashcat_flutter_plugin
  0.1.1, flashcat_tracking_http_client 0.1.0 and flashcat_webview_tracking
  0.1.0 are all published under the flashcat.cloud verified publisher, so
  the "publication pending" note and the dependency_overrides workaround
  no longer apply.
- Fix the logout snippet: setUserInfo() takes a required id, so the
  documented empty call does not compile. The correct API is
  clearUserInfo().
- Fix platform requirements. Flutter >= 3.27.0 and Dart >= 3.6.0 per
  pubspec, Android minSdkVersion >= 23 per build.gradle, iOS >= 13.0 and
  Kotlin >= 2.1.0 per the plugin README. The previous values (Flutter 3.0
  / Dart 3.0 / iOS 12.0 / minSdk 21) would not build.
- Bump the documented SDK version from 0.1.0 to 0.1.1.

New content:
- WebView integration via trackDatadogEvents, including the Android
  JavaScriptMode.unrestricted requirement.
- DatadogClient and the HttpOverrides.global caveat for network tracking.
- Account attribution, addUserExtraInfo, clearAllData and
  attachToBackgroundIsolate.
- version / service / flavor, including the '+' -> '-' tag normalization
  that symbol upload depends on.
- firstPartyHostsWithTracingHeaders with the TracingHeaderType options,
  and traceContextInjection.
- Six previously undocumented RUM options (vitalUpdateFrequency,
  reportFlutterPerformance, initialResourceThreshold, trackNonFatalAnrs,
  appHangThreshold) plus the BatchSize / UploadFrequency /
  BatchProcessingLevel enum values.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Fiona2016 Fiona2016 closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant