chore: bump go-flashduty to v0.6.0 and regenerate CLI commands - #124
Merged
Conversation
Picks up four spec fixes from the SDK: automation timezone fallback (server default, not UTC), channel-create group.time_window units (minutes, not seconds), datasource-info's credential description, and real request schemas for status-page update/delete. The last one is a breaking change downstream: status-page update and delete previously took no request fields at all (an EmptyRequest spec bug), so `status-page update`/`delete` gain real flags — page_id plus, for update, all the page's editable fields (name, url_name, custom_domain, page_title, logo, dark_logo, logo_url, favicon, page_header, page_footer, date_view, display_uptime_mode, custom_links, contact_info, subscription, template_preference). Regenerated via `go run ./internal/cmd/cligen` (Cobra commands) and `go run ./internal/cmd/skilldoc gen` (skill reference cards).
datasource-info (and the create/update responses) now describe the payload as returned exactly as configured, with no masking. Add a Gotcha so the agent treats that output as sensitive rather than dumping it into logs or forwarding it to another tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/flashcatcloud/go-flashdutyv0.5.13 → v0.6.0 and regenerates the CLI's generated command layer (internal/cmd/cligen) and skill reference cards (internal/cmd/skilldoc gen) against it.--timezonehelp text — falls back to the server default, not UTC, when omittedgroup.time_windowhelp text — minutes, not secondsEmptyRequest), even though they always accepted real fields server-side.status-page updatenow exposes--page-id(required) plus all the page's editable fields (name, url-name, custom-domain, page-title, logo, dark-logo, logo-url, favicon, page-header, page-footer, date-view, display-uptime-mode, custom_links/subscription via--data, contact-info, template-preference);status-page deleteexposes--page-id(required). This is a breaking change to the generated Go API (StatusPagesService.Update/.Deletenow take a request param) but a pure improvement for CLI users — verified--helpoutput on both.skills/flashduty/reference/monit.mdnoting thatdatasource-info(and create/update responses) return credentials exactly as configured, with no masking — treat the output as sensitive.Test plan
go build ./...go test -race ./...— all packages passgo run ./internal/cmd/skilldoc check— cards OKmake fmt/make lint— 0 issues, no additional diff./bin/flashduty status-page update --helpand... delete --help— confirmed real flags render correctlyzz_generated_*.gofiles,safari.md/status-page.mdgenerated fences, and the one hand-writtenmonit.mdGotcha line changed