feat(mapping): export manual_mapping and merge_mappings from package root - #21
Open
protosphinx wants to merge 1 commit into
Open
feat(mapping): export manual_mapping and merge_mappings from package root#21protosphinx wants to merge 1 commit into
protosphinx wants to merge 1 commit into
Conversation
…root Both strategies were implemented and tested in v0.6 but were only accessible via pm_rag.mapping, not from pm_rag directly. This exposes them in __init__.py alongside the other mapping strategies.
Member
Author
|
auto-deferred for human review: modifies pm_rag/init.py (intentional public API surface addition) Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
manual_mappingandmerge_mappingswere implemented and thoroughly tested as part of the v0.5/v0.6 work, and they appear in the README's strategy table. However, both were only accessible viapm_rag.mapping, not viafrom pm_rag import .... Users following the README examples or the module docstring expect all four strategies to be importable from the package root. This closes that gap.What
manual_mappingto thepm_rag/__init__.pyimport block and__all__.merge_mappingsto thepm_rag/__init__.pyimport block and__all__.Tests
python3 -m pytest -q). The strategies are already covered bytests/test_mapping_manual.pyandtests/test_mapping_merge.py; this change just makes them importable at the top level.Self-merge gate
pm_rag/__init__.pyGate verdict: auto-deferred for human review: modifies pm_rag/init.py (public API surface change, intentional)
Generated by Claude Code