GameState: Fix "Guessed quest ..." message when running in editor - #2640
Open
wjt wants to merge 1 commit into
Open
GameState: Fix "Guessed quest ..." message when running in editor#2640wjt wants to merge 1 commit into
wjt wants to merge 1 commit into
Conversation
For reasons unknown (to me), `quest.resource_path` is blank in this code path when I run a scene in the editor with F6: > Guessed quest from scene res://scenes/dev/basics/teleporter/teleporter_test_2.tscn (Note the double space.) We already know the quest's path because we loaded it by path after guessing it. Print that instead. Move the print to before the `ResourceLoader.load()` call: if that call fails, then the messages will be in a more logical order.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/gamestate-fix-guessed-quest-message-when-running-in-editor/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
felixwalberg
approved these changes
Jul 31, 2026
felixwalberg
left a comment
felixwalberg
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, if the quest path is already known from the path we used to guess it there is no need to try and get it another way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons unknown (to me),
quest.resource_pathis blank in this codepath when I run a scene in the editor with F6:
(Note the double space.)
We already know the quest's path because we loaded it by path after
guessing it. Print that instead. Move the print to before the
ResourceLoader.load()call: if that call fails, then the messages willbe in a more logical order.