Create grapple gym for dev archipelago - #2639
Open
felixwalberg wants to merge 4 commits into
Open
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/dev-archipelago-grapple-gym/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design two scenes,
grapple_gym_1.tscnandgrapple_gym_2.tscnto show off features of the grapple mechanic.The highlights are:
Gym 1:
Gym 2:
hookable_needle.tscnhas a longer range than default grappleall_hooked.gdscript can be used to trigger events in the gameGym 2 uses a regular
Camera2Dand adjusts zoom because thePhantomCamera2Dwas inconsistent in having the player centered. Since I was working max distances, the targets often were out of frame. I avoided chaining together enough needles that the target would be out of frame as well.Gym 2 also has text labels to notate distance. Is there an accessibility standard in terms of font size?
Gym 2 is accessible from the end of Gym 1. I think it makes sense to be able to use both, but I thought Gym 2 should also exist as its own
quest.tresso that a user in Dev Archipelago can go directly to experimenting with range rather than having to play through additional scenes.In designing the visual examples of the reach, it made me wish there was an easier way to see the "reachable" area of a
hookable_pin.tscn. Sincehookable_needle.tscnhas its ownHookControlnode, there is a visual indicator (at least in the positive x direction) of how much further you can reach from it. If it would be possible to have an inverse indicator (something like a marker 200px away from the edge of theHookableAreain each direction (and maybe one for the longer thread as well), then that might help with designing grapple levels with the pins in reach. For finding how far away I had placed the pins, I was printing theglobal_positionof thePlayerto see how far out I would need to go.I would love to get some feedback on whether these scenes do enough to get across supportive structure (either through signs or other visual clues) while also still encouraging users to be creative/diverge from the basics.
Resolves #2536, #1788