fix(@vue-vuetify): reuse the parent AJV#2602
Open
KiaraGrouwstra wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KiaraGrouwstra
force-pushed
the
reuse-ajv
branch
from
July 19, 2026 12:32
1f9b485 to
43acbc3
Compare
KiaraGrouwstra
marked this pull request as draft
July 19, 2026 12:38
KiaraGrouwstra
force-pushed
the
reuse-ajv
branch
2 times, most recently
from
July 19, 2026 12:54
13b618d to
90a7ff6
Compare
KiaraGrouwstra
marked this pull request as ready for review
July 19, 2026 12:58
lucas-koehler
left a comment
Contributor
There was a problem hiding this comment.
Hi @KiaraGrouwstra ,
thank you very much for contributing to JSON Forms ❤️
I had a look at the change and I don't think it makes a difference:
useJsonForms() of the vue package already injects the JSON Forms core state. Its ajv property should be the same ajv as injected by useAjv(). See useAjvs code here:
jsonforms/packages/vue/src/jsonFormsCompositions.ts
Lines 608 to 620 in 6db5bc8
Am I missing something that makes this change necessary?
KiaraGrouwstra
force-pushed
the
reuse-ajv
branch
from
July 20, 2026 09:34
90a7ff6 to
7b6d39b
Compare
…m's AJV Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>
Reuse the same AJV instance throughout JSONForms. Ensures that user configuration of AJV is retained. Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>
KiaraGrouwstra
force-pushed
the
reuse-ajv
branch
from
July 20, 2026 09:38
7b6d39b to
f734784
Compare
Author
|
Hi @lucas-koehler, thanks for your response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the same AJV instance in @vue-vuetify.
Ensures that user configuration of AJV is retained.
Disclaimer: I used a coding agent in the creation of this patch.