hmon: Define configuration schema and Loader C++ API#340
Draft
eduard-moskalchuk wants to merge 1 commit into
Draft
hmon: Define configuration schema and Loader C++ API#340eduard-moskalchuk wants to merge 1 commit into
eduard-moskalchuk wants to merge 1 commit into
Conversation
eduard-moskalchuk
requested a deployment
to
workflow-approval
July 21, 2026 15:08 — with
GitHub Actions
Waiting
eduard-moskalchuk
requested a deployment
to
workflow-approval
July 21, 2026 15:08 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
eduard-moskalchuk
marked this pull request as draft
July 21, 2026 15:09
|
The created documentation from the pull request is available at: docu-html |
arkjedrz
reviewed
Jul 22, 2026
| public: | ||
| virtual ~HealthMonitorLoader() = default; | ||
|
|
||
| static std::unique_ptr<HealthMonitorLoader> Create(); |
Contributor
There was a problem hiding this comment.
This is unnecessary, it enforces creation with factory method and allocation on a heap. Remove it.
arkjedrz
reviewed
Jul 22, 2026
| } | ||
|
|
||
| /// Thread parameters for the monitoring thread. | ||
| table ThreadParameters { |
Contributor
There was a problem hiding this comment.
What if certain parameters are optional?
Contributor
Author
There was a problem hiding this comment.
Everything is optional unless explicitly marked as required, as I understand.
eduard-moskalchuk
force-pushed
the
edmo_health_monitor_config
branch
from
July 22, 2026 15:07
8c18416 to
7863fe8
Compare
eduard-moskalchuk
requested a deployment
to
workflow-approval
July 22, 2026 15:07 — with
GitHub Actions
Waiting
eduard-moskalchuk
requested a deployment
to
workflow-approval
July 22, 2026 15:07 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.