Skip to content

Clarify Application::Run() documentation#324

Open
shegazyy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/clarify-run-method-documentation
Open

Clarify Application::Run() documentation#324
shegazyy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/clarify-run-method-documentation

Conversation

@shegazyy

Copy link
Copy Markdown
Contributor

The previous doc had two problems: the \return tag was a copy-paste from Initialize() ("0 on successful initialization"), and there was no mention that Run() blocks the calling thread until the stop_token fires.

Fixes #158

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 3eb0abaa-c7cb-473a-a19f-15b07df88eab
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (32 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2767 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5498 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7432 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10275 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.965s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@shegazyy

Copy link
Copy Markdown
Contributor Author

Hey @BjoernAtBosch 👋ready for review whenever you have the time.

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

The previous doc had two problems: the \return tag was a copy-paste
from Initialize() ("0 on successful initialization"), and there was no
mention that Run() blocks the calling thread until the stop_token fires.

Fixes eclipse-score#158

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@shegazyy
shegazyy force-pushed the fix/clarify-run-method-documentation branch from 9b31fc6 to 4f08857 Compare July 21, 2026 10:42
@shegazyy
shegazyy requested a deployment to workflow-approval July 21, 2026 10:42 — with GitHub Actions Waiting
@shegazyy
shegazyy requested a deployment to workflow-approval July 21, 2026 10:42 — with GitHub Actions Waiting
@anmittag

Copy link
Copy Markdown
Member

@shegazyy some checks are failing, are you adapting or deleting the PR?

@anmittag anmittag moved this from Backlog to Ready in LCM - Lifecycle & Health FT Jul 21, 2026
@shegazyy
shegazyy requested a deployment to workflow-approval July 21, 2026 13:02 — with GitHub Actions Waiting
@shegazyy
shegazyy requested a deployment to workflow-approval July 21, 2026 13:02 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

Improvement: Documentation how method Application::Run() works

2 participants