Restore settle delay in code mining test fixtures - #4218
Merged
vogella merged 1 commit intoJul 31, 2026
Conversation
Reverts 13b7e48. Removing DisplayHelper.sleep(display, 1000) from CodeMiningTest.setUp() and CodeMiningLineHeaderAnnotationTest.setUp() made CodeMiningTest.testCodeMiningCompletableFutureReturnsNull() fail sporadically on the I-builds. The reasoning behind the removal only covered the code minings, not the reconciler. AbstractReconciler.startReconciling() schedules a job that waits fDelay before running initialProcess() and starting the worker thread, so the sleep was what let the reconciler finish starting up before a test ran. Without it, the document change in the test body arrives mid-startup and takes an extra delay cycle before it is reconciled, which on a loaded machine exceeds the 3s assertion budget. The two affected tests are the only ones in the class that rely on the reconciler picking up a document change rather than on a setCodeMiningProviders() call after the document is set. Also reset DelayedEchoCodeMiningProvider.DELAY in tearDown, since testCodeMiningCtrlHome() raises the static field to 500 and every later test in the class inherited the slower provider. Fixes eclipse-platform#4217
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts 13b7e48, which made
CodeMiningTest.testCodeMiningCompletableFutureReturnsNull()fail sporadically on the I-builds.The reasoning behind removing the settle only covered the code minings, not the reconciler.
AbstractReconciler.startReconciling()schedules a job that waitsfDelaybefore runninginitialProcess()and starting the worker thread, so the sleep was what let the reconciler finish starting up before a test ran. Without it the document change in the test body arrives mid-startup and takes an extra delay cycle before it is reconciled, which on a loaded machine exceeds the 3s assertion budget. The two affected tests are the only ones in the class that rely on the reconciler picking up a document change rather than on asetCodeMiningProviders()call issued after the document is set.Also resets
DelayedEchoCodeMiningProvider.DELAYintearDown, sincetestCodeMiningCtrlHome()raises that static field to 500 and every later test in the class inherited the slower provider.Fixes #4217