Skip to content

Show the layout spy widgets in a tree - #2388

Open
vogella wants to merge 1 commit into
eclipse-pde:masterfrom
vogella:layout-spy-tree-view
Open

Show the layout spy widgets in a tree#2388
vogella wants to merge 1 commit into
eclipse-pde:masterfrom
vogella:layout-spy-tree-view

Conversation

@vogella

@vogella vogella commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Reworks the SWT layout spy to show the full control hierarchy in a tree instead of a single-level child list, so ancestors, siblings and descendants are visible at once and any node can be selected directly. The layout and diagnostics panels follow the tree selection, and a Refresh button re-reads the hierarchy. A tree context menu copies the diagnostics of the selected node and its children to the clipboard, mirroring the CSS spy, for pasting into bug reports.

The old up/down navigation buttons and their icons are gone, since the tree makes them redundant.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

Test Results

  129 files  ±0    129 suites  ±0   39m 8s ⏱️ + 3m 50s
3 523 tests ±0  3 469 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 372 runs  ±0  9 242 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 6b1864d. ± Comparison against base commit 509c57f.

♻️ This comment has been updated with latest results.

@vogella
vogella force-pushed the layout-spy-tree-view branch 2 times, most recently from 7f3f9a3 to 59ee499 Compare June 29, 2026 12:22
@vogella
vogella force-pushed the layout-spy-tree-view branch from 59ee499 to 6d43002 Compare June 30, 2026 12:32
@vogella
vogella marked this pull request as ready for review June 30, 2026 12:32
@vogella
vogella force-pushed the layout-spy-tree-view branch 4 times, most recently from 5c7aa5b to 27b3df8 Compare July 6, 2026 11:23
@vogella
vogella force-pushed the layout-spy-tree-view branch from 27b3df8 to 6373a2e Compare July 7, 2026 14:21
@vogella
vogella force-pushed the layout-spy-tree-view branch from 6373a2e to 9a9de6e Compare July 29, 2026 15:28
@vogella vogella changed the title Show the layout spy widgets in a tree and report HiDPI details Show the layout spy widgets in a tree Jul 29, 2026
@vogella
vogella force-pushed the layout-spy-tree-view branch 3 times, most recently from b631e42 to 7c719f6 Compare July 31, 2026 15:02
Replace the single-level child table and the up/down navigation with a
TreeViewer that shows the full SWT control hierarchy, so ancestors,
siblings and descendants are visible at once and any node can be selected
directly. The layout and diagnostics panels are driven by the tree
selection: the layout panel shows the selected control's own layout and
the diagnostics panel shows its geometry.

A Refresh button re-reads the hierarchy, and selecting a node that has
been disposed in the meantime now reports that instead of failing. The
diagnostics also list the font and style of the selected control.

A context menu on the tree copies the diagnostics of the selected node
and its children to the clipboard, mirroring the CSS spy, so the data can
be pasted into bug reports.
@vogella
vogella force-pushed the layout-spy-tree-view branch from 7c719f6 to 6b1864d Compare August 4, 2026 16:51
@vogella

vogella commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

The issue reported by Maven seems unrelated

Some attempts to read artifact osgi.bundle,bcpg,1.82.0 failed: An error occurred while transferring artifact canonical: osgi.bundle,bcpg,1.82.0 from repository https://download.eclipse.org/releases/2025-12/202512101000: Retry another mirror: download from https://www.ftp.saix.net/Eclipse//releases/2025-12/202512101000/plugins/bcpg_1.82.0.jar failed

Planning to merge this one tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant