Create a Python icechunk Storage from obstore - #2160
Draft
kylebarron wants to merge 4 commits into
Draft
Conversation
Contributor
Author
|
FWIW Maybe @vladidobro you'd be interested in testing this because you created #1632 |
This was referenced Jun 4, 2026
Member
Not released yet, but now |
Contributor
Author
|
pyo3-object-store is already updated for pyo3 0.29; but I'll wait for some feedback on this design before updating the PR |
Member
|
I don't have much feedback about the low-level design, but a function like this (or equivalent mapping in obstore to icechunk) would allow saving a few LoC in every VirtualiZarr Icechunk example. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements conversion from an Obstore S3Store. I figure I should get feedback on this overall before expanding this to support GCS and Azure.
This works by using obstore's pickle mechanism to extract the config from a non-statically linked instance of object-store. The configs don't line up cleanly between the two libraries.
And might I add that object-store's config is vastly broader than the config options you support, so any specialized config settings that a user might have defined in obstore will be silently lost on conversion to an icechunk store. We could at least print a warning? Or should we error?
I don't know how to use icechunk so I don't have a way to test this PR myself, though I'm sure someone from devseed could help out.
I have not yet used AI in the creation of this PR.
Closes #1632