CAAS-2680: handle broken references - #252
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses CAAS-2680 by making the CaaSMapper resilient to broken references coming from CaaS payloads, specifically cases where a reference identifier is null/missing, so mapping can continue without throwing.
Changes:
- Add guards for
null/missing identifiers inDatasetReference,FS_REFERENCE(Media, PageRef/GCAPage), andFS_INDEXrecords, logging a warning and returningnullinstead of throwing. - Add unit regression coverage to ensure broken references are skipped (mapped to
null) and do not trigger reference registration, while the rest of an element still maps normally. - Increase an integration-test precondition timeout to reduce flakiness while waiting for CaaS propagation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules/CaaSMapper.ts | Adds defensive checks + warnings to skip broken references instead of calling unifyId with null. |
| src/modules/CaaSMapper.spec.ts | Adds targeted unit/regression tests covering broken-reference scenarios and ensuring mapping continues. |
| integrationtests/FSXAProxyApiRemoteProjects.test.ts | Extends wait timeout for remote PageRef availability in CaaS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions Bot
added a commit
that referenced
this pull request
Jul 24, 2026
## [11.2.2](v11.2.1...v11.2.2) (2026-07-24) ### Bug Fixes * **CaaSMapper:** handle broken references ([#252](#252)) ([ff67683](ff67683))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by returning null for entries with null identifiers