Delete or upgrade 3 remaining .NET Fx projects - #12925
Open
gewarren wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the repo-wide snippet modernization effort (Issue #12713) by removing legacy .NET Framework–style snippet projects and upgrading remaining snippet projects to SDK-style targeting .NET 10.
Changes:
- Upgraded the
System.Decimal.Parsesnippet project to SDK-stylenet10.0and refactored the associated code-behind to remove ASP.NET dependencies. - Removed the legacy
System.IdentityModel.Tokens.SecurityToken“Custom Token” sample snippet sources and stripped the corresponding example blocks from the API XML. - Deleted the
System.Windows.Forms.HtmlElementErrorEventArgsWinForms snippet projects/resources and removed the examples from its XML docs (but other docs still reference those deleted snippets).
Reviewed changes
Copilot reviewed 29 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Windows.Forms/HtmlElementErrorEventArgs.xml | Removes embedded examples and replaces type-level remarks text. |
| xml/System.IdentityModel.Tokens/SecurityToken.xml | Removes example sections that referenced legacy WIF sample snippets. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/My Project/MySettings.vb | Deletes VB WinForms project-generated settings code. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/My Project/MySettings.settings | Deletes VB WinForms project settings metadata. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/My Project/MyResources.vb | Deletes VB WinForms project-generated resources wrapper. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/My Project/MyResources.resx | Deletes VB WinForms project resource file. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/My Project/MyEvents.vb | Deletes VB WinForms project “MyApplication” events stub. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/HtmlWindowProject.vbproj | Deletes the VB snippet project file. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.vb | Deletes the VB WinForms sample source used for snippet regions. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.resx | Deletes the VB WinForms form resources. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.Designer.vb | Deletes the VB WinForms designer file. |
| snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/app.config | Deletes the VB WinForms app.config. |
| snippets/csharp/System/Decimal/Parse/parsemethod.csproj | Converts legacy MSBuild project to SDK-style net10.0. |
| snippets/csharp/System/Decimal/Parse/Default.aspx.cs | Refactors snippet code to compile without ASP.NET types. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/snippets.5000.json | Deletes snippet host configuration for the removed WinForms sample. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Program.cs | Deletes the C# WinForms sample entry point. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/HtmlWindowProjectCSharp.csproj | Deletes the legacy C# WinForms snippet project file. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.resx | Deletes the C# WinForms form resources. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.Designer.cs | Deletes the C# WinForms designer file. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.cs | Deletes the C# WinForms sample source used for snippet regions. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Configuration/Settings.cs | Deletes generated settings code for removed WinForms project. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Configuration/Resources.resx | Deletes generated resources for removed WinForms project. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Configuration/Resources.Designer.cs | Deletes generated resources wrapper for removed WinForms project. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Configuration/AssemblyInfo.cs | Deletes legacy assembly attributes file for removed WinForms project. |
| snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/app.config | Deletes legacy WinForms app.config. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/simplewebtokenkeyidentifierclause.cs | Deletes WIF “Custom Token” sample source. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/simplewebtokenhandler.cs | Deletes WIF “Custom Token” sample source. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/simplewebtokenconstants.cs | Deletes WIF “Custom Token” sample source. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/simplewebtoken.csproj | Deletes legacy MSBuild project for WIF sample. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/simplewebtoken.cs | Deletes WIF “Custom Token” sample source. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/properties/assemblyinfo.cs | Deletes legacy assembly attributes for WIF sample. |
| snippets/csharp/System.IdentityModel.Tokens/SecurityToken/Overview/customissuertokenresolver.cs | Deletes WIF “Custom Token” sample source. |
Files not reviewed (3)
- snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Configuration/Resources.Designer.cs: Generated file
- snippets/csharp/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.Designer.cs: Generated file
- snippets/visualbasic/System.Windows.Forms/HtmlElementErrorEventArgs/Overview/Form1.Designer.vb: Generated file
gewarren
enabled auto-merge (squash)
August 1, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #12713.