Fix SOS CLRMA crash in the native (non-hosted) !analyze path

[hoyosjs]

The exported CLRMACreateInstance entrypoint runs outside any SOS command, but the native Target/Runtime/DataTarget/Host fallback objects read the command-scoped g_Ext* globals, which are null outside a command. !analyze hit this and crashed in Target::GetOperatingSystem.

These objects now use the session-lifetime IDebuggerServices (backed by DbgEngServices/LLDBServices) instead of g_Ext*, so they are valid regardless of command scope. OS-dependent choices, including the CLRMA module-name separator, now come from ITarget::GetOperatingSystem().

Rejected repopulating g_Ext* for the exported path: it preserves the command-scoped-global coupling instead of fixing the lifetime mismatch.

Behavior change: DataTarget::GetMachineType now normalizes ARM64EC to AMD64 (via DbgEngServices::GetProcessorType), matching the rest of SOS; AMD64/ARM64 are unaffected.

[Copilot]

Pull request overview

This PR fixes a crash in SOS CLRMA’s native (non-hosted) path by removing reliance on command-scoped g_Ext* globals and instead using session-lifetime IDebuggerServices for OS detection, module enumeration, memory access, and thread context operations—so the exported CLRMACreateInstance entrypoint can run safely outside SOS command scope.

Changes:

• Refactors SOS native Host/Target/DataTarget/Runtime fallback implementations to use IDebuggerServices instead of g_Ext* globals.
• Moves OS-dependent behavior (notably CLRMA module-name path separator selection) to use ITarget::GetOperatingSystem().
• Adds a unit test script coverage scenario to exercise the native CLRMA path under cdb when no managed host is present.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/SOS.UnitTests/Scripts/StackAndOtherTests.script	Adds coverage to exercise the non-hosted CLRMA path under cdb and validate OS/thread-context dependent behavior.
src/SOS/Strike/sosextensions.cpp	Passes session-lifetime debugger services into the local Host singleton creation.
src/SOS/Strike/platform/targetimpl.h	Updates Target singleton API to require debugger services; adjusts runtime switching behavior.
src/SOS/Strike/platform/targetimpl.cpp	Implements Target to use IDebuggerServices for OS detection and process ID queries; manages debugger-service lifetime.
src/SOS/Strike/platform/runtimeimpl.cpp	Replaces g_Ext* usage with IDebuggerServices for module enumeration and memory reads in runtime discovery.
src/SOS/Strike/platform/hostimpl.h	Updates Host singleton API to accept/store IDebuggerServices.
src/SOS/Strike/platform/hostimpl.cpp	Implements Host storing IDebuggerServices and using it to create the local Target.
src/SOS/Strike/platform/datatarget.h	Stores IDebuggerServices in DataTarget and adds destructor for releasing it.
src/SOS/Strike/platform/datatarget.cpp	Routes DataTarget operations (machine type, modules, memory, thread context, alloc/free) through IDebuggerServices/IRemoteMemoryService.
src/SOS/Strike/clrma/managedanalysis.cpp	Chooses CLRMA path separator based on ITarget::GetOperatingSystem() instead of command-scoped target checks.

Suppressed comments (2)

src/SOS/Strike/platform/hostimpl.cpp:40

• Host::GetInstance can construct the singleton with a null debuggerServices pointer, which will later crash when Host uses it (and currently crashes immediately in Host::Host). Validate debuggerServices when creating the singleton and fail fast if it's missing.

IHost* Host::GetInstance(IDebuggerServices* debuggerServices)
{
    if (s_host == nullptr)
    {
        s_host = new Host(debuggerServices);
    }
    s_host->AddRef();
    return s_host;
}

src/SOS/Strike/platform/hostimpl.cpp:107

• Host::GetCurrentTarget returns S_OK even if Target::GetInstance fails and returns nullptr (e.g., if debugger services were not available when the Host was created). Return an error in that case so callers don't dereference a null target.

HRESULT Host::GetCurrentTarget(ITarget** ppTarget)
{
    if (ppTarget == nullptr)
    {
        return E_INVALIDARG;
    }
    *ppTarget = Target::GetInstance(m_debuggerServices);
    return S_OK;
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.