Fix New-PfbQuotaUser test hang on missing mandatory -UserName - #13
Merged
dmann000 merged 1 commit intoJul 20, 2026
Merged
Conversation
The "throws when neither -UserName nor -UserId is supplied" test invoked the
cmdlet with neither identity parameter. Since -UserName is Mandatory in the
default ('ByName') parameter set, PowerShell's own parameter binder can't
resolve which set applies, falls back to the default, and then prompts
interactively for the missing -UserName instead of letting the cmdlet's own
code run -- hanging forever with no TTY to answer it (reproduced in both a
real interactive terminal and this suite's own non-interactive runner).
Replaced the invocation with a metadata check confirming -UserName and
-UserId are each Mandatory in their own parameter sets, which proves the same
"neither supplied" case is rejected without ever risking the hang.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
juemerson-at-purestorage
pushed a commit
to juemerson-at-purestorage/fb-powershell
that referenced
this pull request
Jul 20, 2026
Removes Remove-PfbSession, New-PfbNetworkAccessPolicy, Remove-PfbNetworkAccessPolicy - they modeled REST endpoints that never existed in any FlashBlade API version (2.0-2.27) and always returned HTTP 405. Sessions are read-only; network-access policies are a fixed built-in set (only their rules are mutable, already covered by New-/Remove-PfbNetworkAccessRule). Nothing that worked stops working. ModuleVersion 2.1.1 -> 2.1.2; manifest FunctionsToExport 526 -> 523; CHANGELOG + ReleaseNotes updated. The ValidateSet/enum fixes (PRs dmann000#13-16) are already on main and are folded into this 2.1.2 release note. Validated: Test-ModuleManifest OK (523 exports), Pester 154 passed / 0 failed / 2 skipped (pwsh 7, 24 suites).
juemerson-at-purestorage
pushed a commit
to juemerson-at-purestorage/fb-powershell
that referenced
this pull request
Jul 22, 2026
…auser-test-hang-prompt Fix New-PfbQuotaUser test hang on missing mandatory -UserName
juemerson-at-purestorage
pushed a commit
to juemerson-at-purestorage/fb-powershell
that referenced
this pull request
Jul 22, 2026
Removes Remove-PfbSession, New-PfbNetworkAccessPolicy, Remove-PfbNetworkAccessPolicy - they modeled REST endpoints that never existed in any FlashBlade API version (2.0-2.27) and always returned HTTP 405. Sessions are read-only; network-access policies are a fixed built-in set (only their rules are mutable, already covered by New-/Remove-PfbNetworkAccessRule). Nothing that worked stops working. ModuleVersion 2.1.1 -> 2.1.2; manifest FunctionsToExport 526 -> 523; CHANGELOG + ReleaseNotes updated. The ValidateSet/enum fixes (PRs dmann000#13-16) are already on main and are folded into this 2.1.2 release note. Validated: Test-ModuleManifest OK (523 exports), Pester 154 passed / 0 failed / 2 skipped (pwsh 7, 24 suites).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests/New-PfbQuotaUser.Tests.ps1invoked the cmdlet with neither identity parameter. Since-UserNameisMandatoryin the default (ByName) parameter set, PowerShell's own parameter binder can't resolve which set applies, falls back to the default, and then prompts interactively for the missing-UserNameinstead of letting the cmdlet's own code run — hanging forever with no TTY to answer it. Reproduced in both a real interactive terminal and a non-interactive test runner.-UserNameand-UserIdare eachMandatoryin their own parameter sets, which proves the same "neither supplied" case is rejected without ever risking the hang.Test plan
Invoke-Pester -Path Tests/New-PfbQuotaUser.Tests.ps1— 7/7 pass, no hangmain(rebased branch point)🤖 Generated with Claude Code