test: Restructure guest_disk tests - #10811
Merged
Merged
Conversation
Move some of the shared logic from tests into the fixture so tests can be written with higher-level helper functions. The modified test fixture models the real GuestOS setup more closely.
|
✅ No security or compliance issues detected. Reviewed everything up to 8293ae6. Security Overview
Detected Code Changes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the guest_disk test suite by moving repeated low-level setup logic into a richer test fixture that more closely models the real GuestOS disk topology (shared Store + A/B Var slots), enabling higher-level upgrade/rollback-style tests.
Changes:
- Introduces
TestFixturewith A/BBootSlots and aPartitionViewhelper to encapsulate per-partition operations (format/open/header inspection/mapper IO). - Updates existing tests to use the higher-level helpers and adds slot-aware upgrade/rollback flows.
- Cleans up and centralizes common helpers (e.g., key derivation, keyslot counting, detached header handling).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blind-oracle
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some of the shared logic from tests into the fixture so tests can be written with higher-level helper functions. The modified test fixture models the real GuestOS setup more closely.