Skip to content

fix(lint): enable revive blank-imports, remove unused import - #863

Open
skevetter wants to merge 1 commit into
mainfrom
lint/blank-imports
Open

fix(lint): enable revive blank-imports, remove unused import#863
skevetter wants to merge 1 commit into
mainfrom
lint/blank-imports

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Removes the unused _ "embed" blank import in pkg/ide/rstudio/rstudio.go — it had no //go:embed directive anywhere in the package, so the import had no effect.
  • Enables the blank-imports revive rule in .golangci.yaml.

This is one rule in an incremental rollout of revive's full rule set, fixed and enabled one rule at a time so main stays green after every merge.

@netlify

netlify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit dcc6ee9
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a7016461cd3de0008167838

@netlify

netlify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit dcc6ee9
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a7016467c5b58000816a513

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e23f52c-097e-4186-9fa8-0fd316e12c2e

📥 Commits

Reviewing files that changed from the base of the PR and between 3114bf2 and dcc6ee9.

📒 Files selected for processing (2)
  • .golangci.yaml
  • pkg/ide/rstudio/rstudio.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

pkg/ide/rstudio/rstudio.go imported "embed" for its side effect but
had no //go:embed directive, so the import did nothing.
@skevetter
skevetter force-pushed the lint/blank-imports branch from b08a895 to dcc6ee9 Compare August 3, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant