chore(lint): enable funcorder.function and revive.enable-all-rules - #862
chore(lint): enable funcorder.function and revive.enable-all-rules#862skevetter wants to merge 1 commit into
Conversation
…rop duplicate rules
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Summary
funcorder.function: trueandrevive.enable-all-rules: truein.golangci.yaml.line-length-limit(duplicateslll),cyclomatic(duplicatescyclop, tuned tomax-complexity: 8),function-length(duplicatesfunlen). Pure config consolidation, no suppression of real issues.Scope note
This is PR1 of a 5-PR stack rolling out these rules across the codebase. It intentionally does not fix the
funcorderfindings the config change surfaces (11 of them, acrosspkg/agent/tunnelserver,pkg/apple,pkg/client/clientimplementation,pkg/dockerfile,pkg/driver/kubernetes,pkg/ide/jetbrains,pkg/ide/openvscode,pkg/platform/client,pkg/platform/remotecommand,pkg/stdio) or the much largerrevive.enable-all-rulesbacklog (~6,800 findings repo-wide, uncapped) — those land in PR2–PR5. Since CI'sgolangci-lint-actionruns withonly-new-issues: true, this config-only diff should not fail CI on pre-existing findings.Marked as draft pending the full stack's review sequencing.