Skip to content

chore(lint): enable funcorder.function and revive.enable-all-rules - #862

Closed
skevetter wants to merge 1 commit into
mainfrom
lint/pr1-funcorder-revive-config
Closed

chore(lint): enable funcorder.function and revive.enable-all-rules#862
skevetter wants to merge 1 commit into
mainfrom
lint/pr1-funcorder-revive-config

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Enables funcorder.function: true and revive.enable-all-rules: true in .golangci.yaml.
  • Disables 3 revive sub-rules that duplicate already-enabled, already-tuned linters: line-length-limit (duplicates lll), cyclomatic (duplicates cyclop, tuned to max-complexity: 8), function-length (duplicates funlen). Pure config consolidation, no suppression of real issues.

Scope note

This is PR1 of a 5-PR stack rolling out these rules across the codebase. It intentionally does not fix the funcorder findings the config change surfaces (11 of them, across pkg/agent/tunnelserver, pkg/apple, pkg/client/clientimplementation, pkg/dockerfile, pkg/driver/kubernetes, pkg/ide/jetbrains, pkg/ide/openvscode, pkg/platform/client, pkg/platform/remotecommand, pkg/stdio) or the much larger revive.enable-all-rules backlog (~6,800 findings repo-wide, uncapped) — those land in PR2–PR5. Since CI's golangci-lint-action runs with only-new-issues: true, this config-only diff should not fail CI on pre-existing findings.

Marked as draft pending the full stack's review sequencing.

@netlify

netlify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 6c9c665
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a7008fa6b15f80008925c4b

@netlify

netlify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 6c9c665
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a7008fa66216100083e68e2

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f8c85cc9-8cc3-45b7-b777-76e5b7dbdf23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@skevetter skevetter closed this Aug 3, 2026
@skevetter
skevetter deleted the lint/pr1-funcorder-revive-config branch August 3, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant