Don't show span kinds for non-span events#479
Open
nblumhardt-ro wants to merge 1 commit into
Open
Conversation
Assisted-by: Claude:claude-opus-5
nblumhardt-ro
commented
Jul 24, 2026
|
|
||
| if (!string.IsNullOrWhiteSpace(evt.SpanKind)) | ||
| // This temporarily works around an events API bug; non-span events should not carry span kinds. | ||
| if (!string.IsNullOrWhiteSpace(evt.Start) && !string.IsNullOrWhiteSpace(evt.SpanKind)) |
Author
There was a problem hiding this comment.
The use of IsNullOrWhitespace is consistent with the handling of Start a little earlier in the same method, but I believe null equality checks are sufficient; I didn't want to create more churn in this PR, but we might want to review OutputFormat, which is a bit older than NativeFormatter, and get the two into agreement about what communicates a "missing" value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The events API incorrectly sets
EventEntity.SpanKindtoInternal(a defaultenumvalue) for events with no associated span kind. The PR works around this by making span kind emission conditional on the presence ofStart; we'll need to make a full fix on the Seq side.