Rpadma2/17917 28 - #18728
Closed
rpadma2 wants to merge 6 commits into
Closed
Conversation
Because Object fetch tasks retain caller-owned IOD pointers, and RPC encoding may be deferred or repeated during a retry, if an asynchronous caller clears or reuses an IOD before completion, encoding can observe a positive iod_nr with a NULL iod_recxs, DAOS engine can crash in this case before it doesn't do enough defensive check. This patch includes these changes: - Reject array IODs with a positive extent count and no recx array during client validation and RPC encoding. - Add a server-side guard to prevent malformed requests from reaching VOS. Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
For admin stopped reintegration, FAIL_RECLAIM needs to broadcast to reint engines to cleanup space, as following rebuild start will not do pool_discard again. Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-unit-test: true Skip-fault-injection-test: true Test-tag: test_fill_destroy_cont_loop Signed-off-by: rpadma2 <ravindran.padmanabhan@hpe.com>
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-unit-test: true Skip-fault-injection-test: true Test-tag: test_fill_destroy_cont_loop Signed-off-by: rpadma2 <ravindran.padmanabhan@hpe.com>
Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-unit-test: true Skip-fault-injection-test: true Test-tag: test_fill_destroy_cont_loop Signed-off-by: rpadma2 <ravindran.padmanabhan@hpe.com>
Collaborator
|
Test stage Functional Hardware Medium completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18728/3/execution/node/1348/log |
Collaborator
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18728/3/execution/node/1445/log |
…ased. Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-unit-test: true Skip-fault-injection-test: true Test-tag: test_fill_destroy_cont_loop Signed-off-by: rpadma2 <ravindran.padmanabhan@hpe.com>
Contributor
Author
|
Having merge conflicts... Closing this PR and will create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip-func-hw-test-medium: false
Skip-func-hw-test-medium-md-on-ssd: false
Skip-unit-test: true
Skip-fault-injection-test: true
Test-tag: test_fill_destroy_cont_loop
Steps for the author:
After all prior steps are complete: