-
Notifications
You must be signed in to change notification settings - Fork 0
Fix spec drifting in the design document #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
306f91f
Check order limit price
fedgiac 6ceba6a
Check order amounts
fedgiac be30897
Clarify where the limit price validation comes from
fedgiac a205926
Clarify how pushes are split
fedgiac ebb6532
Consistently use .into() for instructions
fedgiac 40b93d6
Have parsing iterator directly decode u64
fedgiac 5d045ff
Sweep all options in locality test
fedgiac 26af609
Merge branch 'main' into limit-price-check
fedgiac 82f2684
Fix merge
fedgiac 5a76fd9
Merge branch 'limit-price-check' into amounts-check
fedgiac ae32173
Condense destructuring
fedgiac 10bb036
Collect to aray in test
fedgiac cbcd5ca
Collect to array in test, again
fedgiac 9503b18
More efficient order in `if`
fedgiac 5dcfde4
Skip unnecessary validation in edge case
fedgiac db36907
Simplify comments
fedgiac ac83628
impl TryFrom<&[u8]> for OrderAccount
fedgiac 04ec557
Typo
fedgiac c3f3719
Fix spec drifting in the design document
fedgiac 05eb465
Merge branch 'main' into limit-price-check
fedgiac cf18dba
Merge branch 'limit-price-check' into amounts-check
fedgiac 535a940
Merge branch 'main' into limit-price-check
fedgiac 3a7c2db
Merge branch 'limit-price-check' into amounts-check
kaze-cow 23067ac
Merge branch 'main' into limit-price-check
fedgiac d5e3fdb
Merge branch 'limit-price-check' into amounts-check
fedgiac d2d8a80
Merge branch 'main' into amounts-check
fedgiac 1ee96cb
Use simplified decoding mechanism in settle CLI
fedgiac fe86c69
Define IntentSpec
fedgiac 7dfc653
Merge branch 'main' into amounts-check
fedgiac 887efb2
Merge branch 'amounts-check' into fix-spec-drift
fedgiac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: buffer accounts are still used to Pull funds from users, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really:
BeginSettleallows solvers to specify where to send the funds. This could be any arbitrary account, and so they don't need to even specify the sell token buffer account in the list of accounts. But if a solver wants, then the buffers can be used, so if they need it for some reason they can work with it.