Skip to content

Fix Prometheus integration payload and validation endpoints#224

Open
Rohithmatham12 wants to merge 1 commit into
cortexapps:mainfrom
Rohithmatham12:fix-prometheus-add-payload
Open

Fix Prometheus integration payload and validation endpoints#224
Rohithmatham12 wants to merge 1 commit into
cortexapps:mainfrom
Rohithmatham12:fix-prometheus-add-payload

Conversation

@Rohithmatham12

Copy link
Copy Markdown

Summary

  • send Prometheus tenant/default fields with the same camelCase shape used by the API and update command
  • keep password in the generated add payload and add regression assertions for the request body
  • correct Prometheus validate endpoints to the singular configuration validate routes covered by tests

Fixes #136.

Testing

  • CORTEX_BASE_URL=http://localhost CORTEX_API_KEY=test POETRY_CACHE_DIR=/private/tmp/cortexapps-cli-poetry-cache poetry run pytest tests/test_integrations_prometheus.py -k "not add_multiple" -q

Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prometheus add is incorrect - does not include tenant and password parameters

1 participant