deduplicate dependency maskito and date-fns - #2278
Open
dmitrbrvsk wants to merge 2 commits into
Open
Conversation
dmitrbrvsk
requested review from
SiebenSieben,
dHIM24,
fulcanellee and
hextion
as code owners
July 20, 2026 08:13
🦋 Changeset detectedLatest commit: 925fa87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 93 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle size report
|
Coverage Report for CI Build 29727568473Coverage decreased (-0.06%) to 82.104%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
dmitrbrvsk
force-pushed
the
fix/deduplicate-maskito
branch
from
July 20, 2026 08:20
e67b2c0 to
4f4f55f
Compare
dmitrbrvsk
changed the title
… peerDependencies
dmitrbrvsk
force-pushed
the
fix/deduplicate-maskito
branch
from
July 20, 2026 11:34
549d40d to
925fa87
Compare
Contributor
|
а зачем мы выносим зависимости в пир? не пойму как это поможет с размером сборки. если у тебя по семверу всё ровно, твоя сборка будет без дубликатов и так. |
Contributor
Author
а если представить, что условно завтра опять такая же ситуация возникнет: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maskito/core/@maskito/reactдо^4.0.1, чтобы в бандлах потребителей не дублировались версии maskitomaskUtils.prefixPostprocessorдля корректной работы с@maskito/corev4(вставка недостающих символов префикса на нужные позиции)
date-fnsпереведён вpeerDependencies(^4.1.0): приложение должно предоставлять одну версию библиотеки, чтобы она не дублировалась в бандлеприкладываю скрин из отчет команды
yarn bundle-analyzeна проекте