Skip to content

feat/DS-16913_motion_v2 - #2230

Draft
fulcanellee wants to merge 41 commits into
masterfrom
feat/DS-16913_motion_v2
Draft

feat/DS-16913_motion_v2#2230
fulcanellee wants to merge 41 commits into
masterfrom
feat/DS-16913_motion_v2

Conversation

@fulcanellee

@fulcanellee fulcanellee commented May 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-bot Bot commented May 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f5f215d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Entry point Size (minified)
@alfalab/core-components-accordion/index.js 27.6 (+12.70 KB ❌)
@alfalab/core-components-universal-modal/index.js 133.1 (+15.40 KB ❌)
@alfalab/core-components-universal-modal/desktop/index.js 130.5 (+15.50 KB ❌)
@alfalab/core-components-universal-modal/responsive/index.js 133.1 (+15.40 KB ❌)

@coveralls

coveralls commented May 28, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28514757719

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.6%) to 81.55%

Details

  • Coverage decreased (-0.6%) from the base build.
  • Patch coverage: 101 uncovered changes across 6 files (46 of 147 lines covered, 31.29%).
  • 11 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
packages/universal-modal/src/desktop/hooks/use-modal-animation.ts 37 4 10.81%
packages/universal-modal/src/desktop/hooks/use-universal-modal-animation.ts 33 4 12.12%
packages/accordion/src/hooks/use-accordion-spring-animation.ts 36 11 30.56%
packages/base-modal/src/components/animation-wrapper.tsx 18 7 38.89%
packages/base-modal/src/Component.tsx 8 6 75.0%
packages/accordion/src/Component.tsx 11 10 90.91%
Total (8 files) 147 46 31.29%

Coverage Regressions

11 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
packages/gallery/src/Component.tsx 7 85.47%
packages/gallery/src/components/image-viewer/slide.tsx 4 87.88%

Coverage Stats

Coverage Status
Relevant Lines: 11909
Covered Lines: 9780
Line Coverage: 82.12%
Relevant Branches: 2248
Covered Branches: 1765
Branch Coverage: 78.51%
Branches in Coverage %: Yes
Coverage Strength: 236.12 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2230

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2230-alfasans

@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from d022f08 to 42315d5 Compare June 23, 2026 11:10
…n_v2

# Conflicts:
#	packages/button/src/components/base-button/Component.tsx
#	packages/button/src/typings.ts
feat: concept

feat: concept

feat: concept

feat: concept

feat: concept

feat: concept

feat: concept

feat: concept
This reverts commit 7a31458
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from 1603ca3 to a61d915 Compare June 24, 2026 08:08
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from afbc2a1 to 04bb749 Compare June 24, 2026 10:36
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch 2 times, most recently from 55e9ec8 to 49a4463 Compare June 25, 2026 10:07
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from 7742500 to adad8c0 Compare June 25, 2026 10:19
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from 6bad635 to 146b6ec Compare June 26, 2026 08:44
feat: concept

feat: concept

feat: concept

feat: concept

feat: concept
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from 8f7e27f to 00d0917 Compare June 26, 2026 10:03
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from addb512 to ba8b885 Compare June 30, 2026 09:51
@fulcanellee
fulcanellee force-pushed the feat/DS-16913_motion_v2 branch from 6b56caf to 3312d9e Compare June 30, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants