Stop remaining containers on --abort-on-container-exit - #1511
Open
mokibit wants to merge 1 commit into
Open
Conversation
mokibit
force-pushed
the
fix-abort-on-container-exit
branch
2 times, most recently
from
July 21, 2026 18:20
1ab5898 to
012fc40
Compare
Before this change, when using `--abort-on-container-exit` or `--exit-code-from`, exiting one container would leave the remaining containers running in the background. Now, remaining containers are properly stopped when one container exits. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
mokibit
force-pushed
the
fix-abort-on-container-exit
branch
from
July 21, 2026 18:24
012fc40 to
3f6afd6
Compare
p12tic
reviewed
Jul 27, 2026
| ) | ||
| # After one container exits, the others should be stopped. | ||
| # The command should complete within the timeout (all containers stop). | ||
| self.assertNotEqual( |
p12tic
reviewed
Jul 27, 2026
| ) | ||
|
|
||
| # Verify all containers are stopped | ||
| out2, _, _ = self.run_subprocess([ |
Collaborator
There was a problem hiding this comment.
Better count running containers, e.g. using compose ps
p12tic
requested changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when using
--abort-on-container-exitor--exit-code-from, exiting one container would leave the remaining containers running in the background. Now, remaining containers are properly stopped when one container exits.Fixes #679.