Require at least golang 1.23 - #561
Conversation
|
@jnovy you need to run |
|
Also, go 1.22 is no longer supported since go 1.24 is out (i.e. since February 2025). |
|
Thanks @kolyshkin - silly me forgetting this. For golang-1.24 we have a bit of a chicken and egg problem - it still hasn't landed to major current distros. E.g we have still go-1.23.6 in CentOS/RHEL. |
|
@jnovy Still working on this? At least use go mod tidy |
|
Go mod tidy was already done, maybe it makes sense to bump it even more to golang 1.23 now. |
Yes please |
|
@jnovy please |
|
@kolyshkin Maybe we should make this part of your #569 ? |
|
@kolyshkin PTAL - golang requirement is now updated to 1.24 |
| alljournalout, err := getConmonJournalOutput(pid, -1) | ||
| Expect(err).To(BeNil()) | ||
| fmt.Fprintf(GinkgoWriter, alljournalout+"\n") | ||
| fmt.Fprintf(GinkgoWriter, "%s\n", alljournalout) |
There was a problem hiding this comment.
Perhaps it's better/simpler to use fmt.Fprintln here?
| fmt.Fprintf(GinkgoWriter, alljournalout+"\n") | |
| fmt.Fprintf(GinkgoWriter, "%s\n", alljournalout) | |
| fmt.Fprintln(GinkgoWriter, alljournalout) |
|
Currently supported Go versions are 1.23 and 1.24. This will change soon (this month) when Go 1.25 is released. But for now, I guess, we need to support both Go 1.23 and 1.24. |
c963ea1 to
17d0f89
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
@kolyshkin Thanks, I updated the printf statements, I think it's fair to update to 1.25 soon but merge this one first. |
cbc2911 to
e1d514f
Compare
That's not what I meant. Let me try again. The So we should not use 1.24 in there (as we still want 1.23 to be supported), and we should not switch it to 1.25 as soon as it's out (we still want 1.24 to be supported). In general, we should be conservative here, meaning at the very least support all officially supported Go versions (those are 1.23 and 1.24 now). Meaning, today I would put |
Updated go.mod to require Go 1.23 and fixed format string issues in tests to comply with stricter Go requirements. Also update test image to Fedora 42 to ensure it runs recent golang. Fix broken dnf syntax in integration test. Signed-off-by: Jindrich Novy <jnovy@redhat.com>
|
Ok, merging with requiring at least go 1.23 to continue with your PR. |
3 participants
No description provided.