Skip to content

pg19 - Restore tdigest aggregate test plan intent - #8681

Open
ihalatci wants to merge 1 commit into
pg19-supportfrom
ihalatci-pg19-tdigest-plan-intent
Open

pg19 - Restore tdigest aggregate test plan intent#8681
ihalatci wants to merge 1 commit into
pg19-supportfrom
ihalatci-pg19-tdigest-plan-intent

Conversation

@ihalatci

Copy link
Copy Markdown
Contributor

Summary

  • disable citus.allow_aggregate_worker_combine_on_internal_types in tdigest_aggregate_support so the regression test continues to assert tdigest-specific distributed plan shapes instead of the generic internal-state worker-combine path
  • update the primary expected output and the existing _0/_1 alternatives with the new SET echo
  • keep the existing alternative semantics: _0 covers extension-absent output and _1 covers accepted tdigest result-value variation
  • account for PostgreSQL 19 Beta 2's undefined-function DETAIL through the normalization already present on the refreshed pg19-support base (ca86a5d95); a separate _2 alternative was validated during development but removed because that base normalization makes it redundant and unreachable

Validation

  • -Werror builds: PostgreSQL 17.10, 18.4, and 19 Beta 2
  • focused tdigest_aggregate_support schedule with tdigest installed: passed on PostgreSQL 17.10, 18.4, and 19 Beta 2
  • focused schedule without tdigest: PostgreSQL 17.10 and 18.4 matched _0; PostgreSQL 19 Beta 2's raw DETAIL normalized and matched _0
  • make check-style
  • git diff --check

Closes #8667

This PR intentionally targets the non-default pg19-support branch. GitHub may not automatically close #8667 when this merges there; closure should be confirmed when the support branch is subsequently integrated into the default branch.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 242038e7-c2b1-4341-b25d-a9f69a4e9981
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.80%. Comparing base (cfb4063) to head (9869797).

Additional details and impacted files
@@              Coverage Diff              @@
##           pg19-support    #8681   +/-   ##
=============================================
  Coverage         88.79%   88.80%           
=============================================
  Files               288      288           
  Lines             64416    64416           
  Branches           8101     8102    +1     
=============================================
+ Hits              57201    57205    +4     
+ Misses             4877     4874    -3     
+ Partials           2338     2337    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ihalatci
ihalatci marked this pull request as ready for review July 17, 2026 11:53
@ihalatci ihalatci changed the title Restore tdigest aggregate test plan intent pg19 - Restore tdigest aggregate test plan intent Jul 22, 2026
@ihalatci ihalatci linked an issue Jul 22, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore tdigest_aggregate_support test intent

2 participants