Skip to content

Addition of mls::State serialization using the existing serialization options - #458

Closed
BlehPoster wants to merge 1 commit into
cisco:mainfrom
BlehPoster:main
Closed

Addition of mls::State serialization using the existing serialization options#458
BlehPoster wants to merge 1 commit into
cisco:mainfrom
BlehPoster:main

Conversation

@BlehPoster

Copy link
Copy Markdown

Adds TLS_SERIALIZABLE recursively to all required nested structures while keeping member accessibility untouched by adding specific overloaded stream operators.
Known issue: Since serialization requires an empty/existing object, mls::State and its nested structures must be default constructible. As long as serialization is implemented outside of structures, default constructors are mandatory.
Added missing #ifdef(WITH_PQ)

The project builds locally (Linux, Clang 18), and all unit tests are passing.

@kosmakoff

Copy link
Copy Markdown

@BlehPoster I tried your code and it was not deserializing the State correctly - it did not restore public keys, and because of that the restored State failed to execute handle() for example.

I made the fix, if you're interested: kosmakoff@95c574f

@BlehPoster

Copy link
Copy Markdown
Author

Hi @kosmakoff, sorry for the late reply, I will take a look at this.
But since this is stale for so long, I will close this and search for different solutions.

@BlehPoster BlehPoster closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants