ENT-14312: Add back command-dispatcher reports, guarded to only emit in debug mode#151
Merged
Merged
Conversation
The dispatch/status reports promises are now guarded with .DEBUG so they only appear when running in debug mode, matching the equivalent reports in the policy-dispatcher module. Ticket: ENT-14312 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ge2NA5hG9Mr5adSeA78vrD
olehermanse
approved these changes
Jul 17, 2026
olehermanse
marked this pull request as ready for review
July 17, 2026 11:30
Member
olehermanse
changed the title
olehermanse
requested review from
SimonThalvorsen,
craigcomstock,
larsewi,
nickanderson and
victormlg
July 17, 2026 11:31
SimonThalvorsen
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ole Herman · Slack thread
Before: since #150 the command-dispatcher module logs nothing about the commands it dispatches; before that it reported on every run.
After: the per-command report and the "commands_to_run variable not found" report are back, but only shown when running in debug mode.
How: restores the two reports promises removed in #150, with
enabled.DEBUG::/!enabled.DEBUG::class guards matching the equivalent reports in policy-dispatcher (#149).Ticket: ENT-14312