Skip to content

Updated Mack's sigma_interpolation to use "mack" - #1177

Merged
henrydingliu merged 2 commits into
mainfrom
fix/mack_example
Aug 1, 2026
Merged

Updated Mack's sigma_interpolation to use "mack"#1177
henrydingliu merged 2 commits into
mainfrom
fix/mack_example

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Changing interpolation approach to match paper

Related GitHub Issue(s)

closes #1093

Additional Context for Reviewers

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Changes are limited to a documentation notebook example; no library code paths are modified in this diff.

Overview
Updates the MackChainladder gallery notebook so the worked example uses Development(sigma_interpolation='mack') instead of Development(average='volume'), aligning Mack standard errors and ultimates with Mack (1994) (page 130 figures).

Also fixes a typo in the intro markdown (“can can” → “can”) and expands comments to describe the Mack interpolation choice.

Reviewed by Cursor Bugbot for commit a4c34c6. Bugbot is set up for automated code reviews on this repo. Configure here.

Changing interpolation approach to match paper
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.0% of exported symbols fully typed (196 / 1305)

Known Ambiguous Unknown Total
Project (head) 196 110 999 1305

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 315
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.14%. Comparing base (bb16128) to head (a4c34c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          91       91           
  Lines        5365     5365           
  Branches      681      681           
=======================================
  Hits         4890     4890           
  Misses        340      340           
  Partials      135      135           
Flag Coverage Δ
unittests 91.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu marked this pull request as ready for review August 1, 2026 02:58
@kennethshsu kennethshsu changed the title Reconcile Mack Example Updated Mack's sigma_interpolation to use "mack" Aug 1, 2026
@kennethshsu

Copy link
Copy Markdown
Member

Updated the PR title.

kennethshsu
kennethshsu previously approved these changes Aug 1, 2026
@kennethshsu
kennethshsu dismissed their stale review August 1, 2026 05:19

Let me dismiss this

@kennethshsu

Copy link
Copy Markdown
Member

@priyam0k do you want to take a look at this?

@priyam0k

priyam0k commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

thanks for the ping @kennethshsu.

change looks right to me. average='volume' is already the default, so the ldfs are unchanged and the only thing moving is sigma, from log-linear to mack. that also lines up with test_mack1994_hardcode in test_mack.py, which fits Development(sigma_interpolation='mack') on raa and reconciles to the same p130 tables, so the gallery example now matches what the test already asserts.

one thing to fix in the same PR: the intro markdown at the top still says "this example does not fully reconcile to the original paper due to the default usage of log-linear sigma interpolation". after this change it does reconcile, so that note is now wrong.

otherwise lgtm.

@henrydingliu

Copy link
Copy Markdown
Member Author

the intro markdown at the top still says "this example does not fully reconcile to the original paper due to the default usage of log-linear sigma interpolation".

where are you seeing this?

@priyam0k

priyam0k commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

my mistake, that line's actually on experimental (9dcebfb), not main, so it doesn't apply here. sorry for the mix-up. i did notice a tiny typo in main's intro ("can can") line 30, nothing urgent,

@henrydingliu
henrydingliu merged commit 75c274e into main Aug 1, 2026
15 checks passed
@henrydingliu
henrydingliu deleted the fix/mack_example branch August 1, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MackChainladder calculations not as expected

3 participants