Updated Mack's sigma_interpolation to use "mack" - #1177
Conversation
Changing interpolation approach to match paper
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 91 91
Lines 5365 5365
Branches 681 681
=======================================
Hits 4890 4890
Misses 340 340
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Updated the PR title. |
|
@priyam0k do you want to take a look at this? |
|
thanks for the ping @kennethshsu. change looks right to me. one thing to fix in the same PR: the intro markdown at the top still says "this example does not fully reconcile to the original paper due to the default usage of log-linear sigma interpolation". after this change it does reconcile, so that note is now wrong. otherwise lgtm. |
where are you seeing this? |
|
my mistake, that line's actually on experimental (9dcebfb), not main, so it doesn't apply here. sorry for the mix-up. i did notice a tiny typo in main's intro ("can can") line 30, nothing urgent, |
Summary of Changes
Changing interpolation approach to match paper
Related GitHub Issue(s)
closes #1093
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Changes are limited to a documentation notebook example; no library code paths are modified in this diff.
Overview
Updates the MackChainladder gallery notebook so the worked example uses
Development(sigma_interpolation='mack')instead ofDevelopment(average='volume'), aligning Mack standard errors and ultimates with Mack (1994) (page 130 figures).Also fixes a typo in the intro markdown (“can can” → “can”) and expands comments to describe the Mack interpolation choice.
Reviewed by Cursor Bugbot for commit a4c34c6. Bugbot is set up for automated code reviews on this repo. Configure here.