Skip to content

Using uv for docs & adding automated docs generating in PR - #1171

Open
kennethshsu wants to merge 9 commits into
mainfrom
#976-uv_in_RTC
Open

Using uv for docs & adding automated docs generating in PR#1171
kennethshsu wants to merge 9 commits into
mainfrom
#976-uv_in_RTC

Conversation

@kennethshsu

@kennethshsu kennethshsu commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Related GitHub Issue(s)

Closes #976
Closes #1151

Additional Context for Reviewers

The new doc site built this way doesn't seem to have the double search or pancake icon bugs

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Tooling-only changes to docs build and RTC install; no application or library runtime code is modified.

Overview
Docs and CI workflow now use uv instead of pip for installing the project with the docs extra and running Jupyter Book builds.

On Read the Docs, readthedocs.yaml replaces pip install with uv sync and the docs extra. Contributor docs in docs/README.md show uv sync --extra docs and uv run --directory docs jb build . from the repo root. The PR template checklist matches that path and adds a “do not edit below” section so the checklist stays consistent.

Reviewed by Cursor Bugbot for commit a6fc39e. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 14.9% of exported symbols fully typed (194 / 1300)

Known Ambiguous Unknown Total
Project (head) 194 110 996 1300

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 314
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

Comment thread readthedocs.yaml
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (f48bd83) to head (a6fc39e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   91.27%   90.86%   -0.42%     
==========================================
  Files          91       91              
  Lines        5422     5331      -91     
  Branches      691      677      -14     
==========================================
- Hits         4949     4844     -105     
- Misses        339      347       +8     
- Partials      134      140       +6     
Flag Coverage Δ
unittests 90.86% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethshsu
kennethshsu marked this pull request as draft July 30, 2026 20:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1cc844d. Configure here.

Comment thread docs/intro.md Outdated
@genedan

genedan commented Jul 31, 2026

Copy link
Copy Markdown
Member

I see that you're getting those weird codecov failures too. See #1172 for an example where the only files I changed were pyproject.toml and uv.lock.

I'm pretty sure those lines that are marked as misses are actually getting indirectly hit and that this is just a weird a pytest/codecov bug. I guess we'll need to add some tests to directly hit the lines, despite the minor redundancy involved.

@henrydingliu

Copy link
Copy Markdown
Member

@kennethshsu we should make development versions on rtd hidden.

@kennethshsu

Copy link
Copy Markdown
Member Author

Ya I'm working on it, if you look above in the actions there's actually a RTC build. The webhook isn't working 100% yet and I keep running into errors, trying to resolve.

@henrydingliu

Copy link
Copy Markdown
Member

that's what i mean. that rtd build is not hidden and everyone visiting the docsite can see it.

@kennethshsu
kennethshsu marked this pull request as ready for review July 31, 2026 04:22
@kennethshsu

Copy link
Copy Markdown
Member Author

I see that you're getting those weird codecov failures too. See #1172 for an example where the only files I changed were pyproject.toml and uv.lock.

I'm pretty sure those lines that are marked as misses are actually getting indirectly hit and that this is just a weird a pytest/codecov bug. I guess we'll need to add some tests to directly hit the lines, despite the minor redundancy involved.

Ya this again, I kinda want to increase the threshold again...

@kennethshsu

Copy link
Copy Markdown
Member Author

that's what i mean. that rtd build is not hidden and everyone visiting the docsite can see it.

This should be fixed now (remember to clear your cache).

@henrydingliu

Copy link
Copy Markdown
Member

@kennethshsu getting this when i try to visit the rtd version for this branch
image

also, i'm not seeing a fix for #1151 based on the diff

@kennethshsu kennethshsu changed the title Using uv for docs Using uv for docs & adding automated docs generating in PR Jul 31, 2026
@kennethshsu

Copy link
Copy Markdown
Member Author

@kennethshsu getting this when i try to visit the rtd version for this branch image

Don't go there, click on the link in the checks instead.

Screenshot 2026-07-31 at 1 42 33 PM

also, i'm not seeing a fix for #1151 based on the diff

Ya, I put in the summary that there's no diff on here, it's basically just reading the docs and relink the GitHub webhook on RTC, which is just a fancy way of saying clicking a few buttons in the right order. I only put the ticket here so we can properly track and close out the ticket in the release notes.

@henrydingliu

Copy link
Copy Markdown
Member

o wow, so we can actually get rid of experimental?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Ammend Doctest workflow to attach an artifact of the rendered docs in a ZIP file Dependency gap between RTD build and Github Action

3 participants