Support for Redis connection without SSL certificate verification - #2
Open
tomash wants to merge 1 commit into
Open
Support for Redis connection without SSL certificate verification#2tomash wants to merge 1 commit into
tomash wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA! |
Owner
|
There is a million option like this you may need. Any reason why the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: on Heroku Key-Value addon (Valkey fork of Redis), they use TLS but with a self-signed certificate, as described here:
This PR adds
REDIS_SSL_VERIFYenvironment variable to make it work without patching Pubsubstub's class in-application.A similar PR is coming to shipit-engine. EDIT: Shopify/shipit-engine#1397
No test coverage because no existing spec covers Redis connection, should I add some?