Fix missing SNMPv1 instance values - #24
Merged
Merged
Conversation
bluecmd
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return
Noneinstead of an empty byte string when an SNMPv1 GET requests a non-existing instance.This ports the upstream Net-SNMP fix for net-snmp/net-snmp#414, implemented upstream in commit
b33d6bbe.This PR supersedes #9 with a minimal patch based on the current master branch and adds coverage to the active system-test suite.
Root cause
For SNMPv1, a missing instance is reported through
err_ind. The response still contains a varbind that was being processed as anOCTETSTR, producingb''.This is indistinguishable from a valid empty string value.
Changes
Varbindvalues asNone.Behavior
Before:
sysDescr.123returned(b'',).After:
sysDescr.123returns(None,).Varbind.valandVarbind.typeremainNone.Testing
git diff --checkpassed.