Fix scalar values in SNMP set requests#15
Merged
Conversation
SoundGoof
force-pushed
the
fix/issue-6-set-values
branch
from
July 23, 2026 22:47
06b975f to
718a4ff
Compare
bluecmd
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6 by allowing SNMP SET requests to accept canonical Python scalar values instead of requiring every value to be a
bytesobject.The native extension now:
bytesvalues without modification, including binary OCTET STRING data.str()representation.SystemError.Root Cause
Varbind.valpreserves its original Python type, but the SET implementation passed every value directly toPyBytes_AsStringAndSize().This worked for
bytes, but rejected integers, Python strings, and other scalar values before the SNMP request could be constructed.The conversion helper now distinguishes between byte and non-byte values:
bytesvalues are passed through unchanged.str()and encoded through Python's UTF-8 representation.Testing
The system tests run against a private Ubuntu
snmpdinstance.Coverage includes:
pass_persistINTEGER scalar, used because Ubuntu's packaged agent does not expose a suitable writable INTEGER object.Results: