Skip to content

Add Colorscheme Options - #214

Open
MoonPadUSer wants to merge 1 commit into
masterfrom
add-colorschemes
Open

Add Colorscheme Options#214
MoonPadUSer wants to merge 1 commit into
masterfrom
add-colorschemes

Conversation

@MoonPadUSer

Copy link
Copy Markdown
Contributor

This PR adds the option to choose between 2 colorschemes, one of them being the default red eclipse colorscheme and the other being an experimental blue nebula colorscheme I created, this is mainly to provide an easy way for users to try out colorschemes and give feedback
2020-09-13-204904_1680x1050_scrot

@voidanix voidanix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This does not work apparently, seems to fail with a unknown command: setcolors in the console when pushing the 2 new buttons.
  2. The active button and the pick a colour for the variable /ui_color_active seem clunky and confusing.
  3. Got some whitespace at https://github.com/blue-nebula/base/pull/214/files#diff-59c8b041b4a3f9cd0dfa9d5311b1a7994a540dff82848bb05970571c99ee7f7eR306
  4. The colorscheme_ "containers" (?) should probably have a docstring e.g. why is the default one resetting vars?

Barely knowing any cubescript at all, this is only a general review but hopefully you get the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants