Skip to content

Do not auto-retry native builds before tests - #11

Open
ofalvai wants to merge 1 commit into
masterfrom
push-ptoxmustsqmk
Open

Do not auto-retry native builds before tests#11
ofalvai wants to merge 1 commit into
masterfrom
push-ptoxmustsqmk

Conversation

@ofalvai

@ofalvai ofalvai commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Context

E2E tests perform full native xcodebuild/gradle builds, and those builds can fail for various reasons (this is a kind of verification, even before any E2E test case actually runs). At the moment, those failures are retried automatically, citing:

The first time an iOS project is built, it fails because it does not finish building libReact.a before it builds the test app.

This is probably no longer true, and the retry makes test runs unnecessarily long when there is a genuine failure.

Changes

Remove that retry logic completely.

Also, the old iOS handler ended in return null on the second failure, so a genuinely broken build resolved as success and the failure surfaced later as a confusing "app not installed" error. Now a bad xcodebuild rejects and fails the run directly.

Edit: re-ran CI 4 times just to see if it's flaky, but every run was green.

Summary by CodeRabbit

  • Bug Fixes
    • Simplified Android and iOS build processes by removing automatic retry behavior after build failures.
    • Build failures now surface immediately instead of triggering an automatic cleanup and rebuild attempt.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Android and iOS build methods were simplified to run their release build commands once, removing retry, error-handling, and build-directory cleanup logic.

Changes

Build retry removal

Layer / File(s) Summary
Single build execution
test/test.ts
RNAndroid.buildApp now runs one Gradle release build, while RNIOS.buildApp no longer deletes the build directory or retries after an xcodebuild failure.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing automatic retry logic for native builds before tests.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch push-ptoxmustsqmk

Comment @coderabbitai help to get the list of available commands.

@ofalvai
ofalvai marked this pull request as ready for review July 30, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant