fix(train): correct Networking field names in ModelTrainer intelligen…#6064
Merged
mohamedzeidan2021 merged 2 commits intoJul 21, 2026
Conversation
…t defaults Fixes two bugs in _populate_intelligent_defaults_from_training_job_space() in model_trainer.py that prevent ModelTrainer from working when sagemaker_config has a VpcConfig set. Bug 1: Networking() was passed default_enable_network_isolation, which is not a field in sagemaker-core 2.x. The correct field is enable_network_isolation. This raised a pydantic ValidationError on every train() call when VPC config was present. Bug 2: When updating an existing Networking object, security_group_ids was mistakenly assigned the subnets value from TRAINING_JOB_SUBNETS_PATH instead of security_group_ids from TRAINING_JOB_SECURITY_GROUP_IDS_PATH. Adds unit tests covering both bug paths (fresh Networking construction and updating an existing Networking object). Fix originally from aws#5866; unit tests added here.
mohamedzeidan2021
temporarily deployed
to
auto-approve
July 20, 2026 19:24 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
July 20, 2026 19:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
July 20, 2026 21:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
July 20, 2026 21:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jam-jee
approved these changes
Jul 21, 2026
lucasjia-aws
approved these changes
Jul 21, 2026
mohamedzeidan2021
deleted the
fix/networking-intelligent-defaults-with-tests
branch
July 21, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t defaults
Fixes two bugs in _populate_intelligent_defaults_from_training_job_space() in model_trainer.py that prevent ModelTrainer from working when sagemaker_config has a VpcConfig set.
Bug 1: Networking() was passed default_enable_network_isolation, which is not a field in sagemaker-core 2.x. The correct field is enable_network_isolation. This raised a pydantic ValidationError on every train() call when VPC config was present.
Bug 2: When updating an existing Networking object, security_group_ids was mistakenly assigned the subnets value from TRAINING_JOB_SUBNETS_PATH instead of security_group_ids from TRAINING_JOB_SECURITY_GROUP_IDS_PATH.
Adds unit tests covering both bug paths (fresh Networking construction and updating an existing Networking object).
Fix originally from #5866; unit tests added here.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.