Implement TestParse_Fields in statsd plugin - #2227
Open
gargritik121-a11y wants to merge 2 commits into
Open
Conversation
The test was a stub (if false { t.Errorf("TODO") }) that never ran.
Implement it with 3 subtests covering:
- No template: field defaults to "value"
- Simple measurement.field template: field extracted from bucket
- Multi-segment measurement.measurement.field template: field parsed correctly
gargritik121-a11y
added
the
ready for testing
musa-asad
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestParse_Fields was a stub (if false { t.Errorf(TODO) }) that never ran. This implements it with 3 table-driven subtests covering the field return value of parseName():
All 3 subtests pass locally.