feat(tracing): validate spans mapper against live Transaction Search - #73
Merged
Conversation
…sample and align query filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The spans mapper was written against unverified assumptions; this change validates and corrects it against a raw span sample captured from the live account (OTel-shaped events:
resourceattributestraceld,spanId/parentSpanId,*UnixNanotimestamps,status.code,_aws.xrayenvelope, subsegments arriving as separate events).utils/spans-waterfall.ts- annotation attributes resolved viaannotation_keysenumeration;_aws.xrayenvelope fallbacks for name/namespace/cause; UnixNano→seconds conversion; flat-subsegment reassembly viaparentSpanIdwith in-progress/completed dedup.utils/trace-span-query.ts,utils/spans-query.ts- query filter fields aligned to theattributes.*locations observed in real spans.trace-query-handler.ts- wiring for the above.Testing
tsc --noEmit: clean; eslint: clean.Not in this PR (deliberate)
TRACE_BACKENDremainsxray. The flip tospansis an env-only change on the telemetry stack applied at deploy time - deploys are manual in this repo, so merging this does not change runtime behavior. Cutover procedure and live verification:docs/TRACING_RUNBOOK.md. Follow-up after verified cutover: remove thexray:Get*IAM grant and flip the pinned telemetry test to assert its absence.Known gaps (minor, non-blocking)
status.code = OKwas not observed in the captured sample; mapping is defensive but unconfirmed against live data._aws.xraycause fallback yet.normalizeToSpansTraceIdhas behavioral-only test coverage.