[core] Handle query auth wrappers in split consumers#8711
Draft
discivigour wants to merge 31 commits into
Draft
Conversation
added 6 commits
July 20, 2026 12:00
# Conflicts: # paimon-core/src/main/java/org/apache/paimon/table/ChainGroupReadTable.java
discivigour
force-pushed
the
bug/j/queryAuthSplit
branch
from
July 20, 2026 04:22
96d4d8b to
e756304
Compare
added 14 commits
July 20, 2026 13:06
leaves12138
previously requested changes
Jul 20, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the broad wrapper coverage. I found three blocking wrapper compositions in the current master merge tree: nested query-auth wrappers in lateral PK vector search, fallback wrappers around query-auth splits in Flink dynamic filtering, and score-reader type erasure after authorization filtering. I reproduced the Spark cases with Spark 3 on JDK 11 and the fallback case with a focused Flink 1 regression. The existing focused tests pass, but the positive/composed-path regressions fail as described inline.
leaves12138
dismissed
their stale review
July 20, 2026 10:20
Submitted without the requester explicitly asking for GitHub comments. Withdrawing this review.
added 7 commits
July 20, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failures and incorrect reader routing when query authorization wraps planned splits in
QueryAuthSplitwhile specialized split consumers assume they receive rawDataSplitinstances.The affected paths include:
DataSplitwithChainSplit;DataSplitwithIndexedSplit; andChanges
QueryAuthSplit.unwrap,unwrapDataSplit, andretainAuthhelpers.Splitvalues. Reader dispatch removes only the fallback wrapper and preserves the query-auth wrapper for row filtering and column masking.IndexBootstrapexplicitly disable query auth on its internal latest-snapshot read. This ensures the index is built from the original primary keys instead of query-filtered or column-masked values.DataSplitintoChainSplit, including lightweight andchain-table.streaming.merge-snapshotstarting plans.QueryAuthSplit(ChainSplit)andQueryAuthSplit(DataSplit)through the chain-aware reader while passing the original wrapper to retain authorization context.DataSplitintoIndexedSplit.Tests
mvn -pl paimon-core -am -Pfast-build \ -DfailIfNoTests=false \ -DwildcardSuites=none \ -Dtest=ChainTableFileStoreTableTest,ChainGroupReadTableTest,FallbackReadFileStoreTableTest,DataEvolutionBatchScanTest,IndexBootstrapTest,QueryAuthSplitTest \ testResult: 35 tests passed.
Final validation:
Checkstyle, Spotless, and Maven Enforcer passed.