Reduce log level for PersistenceManager deserialization problems to INFO#9525
Open
matthiasblaesing wants to merge 1 commit into
Open
Reduce log level for PersistenceManager deserialization problems to INFO#9525matthiasblaesing wants to merge 1 commit into
matthiasblaesing wants to merge 1 commit into
Conversation
As part of 892e14c the default detail level of the logging of PersistenceManager problems was reduced and is only retained if FINE lgging is enabled. On the other hand the log level for the shorted message was raised to WARNING from INFO. This causes the problem to become visible to the end user. Logs with level WARNING and an attached exception cause a visible notification via the chain: NbErrorManager -> NotifyExcPanel#notify -> NotifyExcPanel#shallNotify This in turn even shows the detailed message because the content of the serialization problem is attached to the exception via Exceptions.attachLocalizedMessage in XMLSettingsSupport. Closes: apache#9524
mbien
approved these changes
Jul 19, 2026
mbien
left a comment
Member
There was a problem hiding this comment.
didn't know that warning level can open dialogs in some cases
The usual situation when this code path ran was when an opened project was moved while NB was closed, next launch would dump everything into the log. This happened often to me while testing, but I never saw a dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of 892e14c the default detail level of the logging of PersistenceManager problems was reduced and is only retained if FINE lgging is enabled. On the other hand the log level for the shorted message was raised to WARNING from INFO.
This causes the problem to become visible to the end user. Logs with level WARNING and an attached exception cause a visible notification via the chain:
NbErrorManager->NotifyExcPanel#notify->NotifyExcPanel#shallNotifyThis in turn even shows the detailed message because the content of the serialization problem is attached to the exception via
Exceptions.attachLocalizedMessagein
XMLSettingsSupport.Closes: #9524