Knox-3386: LDAP Proxy pages backends - #1332
Closed
handavid wants to merge 2 commits into
Closed
Conversation
Adds a gateway.ldap.max.size.limit and max.time.limit configs to the LDAP Proxy. Thes configs are uses to set the LDAP server's maxSizeLimit and maxTimeLimit fields. The size limit indictes the maximum total number of search results for a request across all pages. The time limit is in milliseconds. Implements paging to the backend LDAP servers. This is controlled by a new "pageSize" config on the LDAP Proxy Backends. A bug was found during testing where the getUserGroups method will doubly retrieve the groups. This has been fixed.
Contributor
Author
Test Results40 tests 40 ✅ 5s ⏱️ Results for commit 4c23e47. |
Contributor
Author
|
closing since pr is identical to #1331. commit will be cherry-picked directly after that PR is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3386 - LDAP Proxy pages backends
What changes were proposed in this pull request?
Adds a gateway.ldap.max.size.limit and max.time.limit configs to the LDAP Proxy. Thes configs are uses to set the LDAP server's maxSizeLimit and maxTimeLimit fields. The size limit indictes the maximum total number of search results for a request across all pages. The time limit is in milliseconds.
Implements paging to the backend LDAP servers. This is controlled by a new "pageSize" config on the LDAP Proxy Backends.
A bug was found during testing where the getUserGroups method will doubly retrieve the groups. This has been fixed.
How was this patch tested?
(Please explain how this patch was tested. For instance: running automated unit/integration tests, manual tests. Please write down your test steps as detailed as possible)
Unit tests were added/updated in LdapProxyBackendTest and LdapProxyBackendSslTest
manual testing was performed against AD by setting the following values in the gateway-site.xml
Logging was increased to DEBUG level to see the paging-related log messages.
Integration Tests
(Please add or update integration tests .github/workflows/tests for the feature you are adding. If no unit test is added, please explain why. Check out .github/workflows/tests/README.md for instructions)
The gateway-site was modified for the workflow tests to set a small page size. This ensure that the proxy needs to page to return the results in the tests.
UI changes
none