build(deps): bump spring-version from 6.2.19 to 7.0.8#2102
build(deps): bump spring-version from 6.2.19 to 7.0.8#2102dependabot[bot] wants to merge 3 commits into
Conversation
dependabot
Bot
added
dependencies
Test Results 1 095 files + 744 1 095 suites +744 4h 23m 10s ⏱️ + 3h 5m 30s Results for commit b0bf123. ± Comparison against base commit 0b6cf76. ♻️ This comment has been updated with latest results. |
|
That's a major version bump. Let me propose a ActiveMQ version to consider this upgrade. |
Bumps `spring-version` from 6.2.19 to 7.0.8. Updates `org.springframework:spring-aop` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-beans` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-context` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-core` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-expression` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-jms` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-tx` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-webmvc` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-web` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-test` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) Updates `org.springframework:spring-oxm` from 6.2.19 to 7.0.8 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.19...v7.0.8) --- updated-dependencies: - dependency-name: org.springframework:spring-aop dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-beans dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-context dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-core dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-expression dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-jms dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-oxm dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-test dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-tx dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-web dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-webmvc dependency-version: 7.0.8 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
a4b1068 to
b0bf123
Compare
|
Hello @cshannon / @mattrpav , |
The biggest problem with Spring 7 is it bumps the minimum Jakarta EE baseline to version 11. I didn't realize that Spring just went EOL for 6.2.x so it's time because there won't be any more security updates. @jbonofre and @mattrpav - I think we need to upgrade to Spring 7.x and Jakarta EE 11 for the upcoming 6.3.0 release now. With Jetty 12.1.x coming it makes sense and is easy enough to upgrade. Thoughts? |
|
Yes, there is no client impact to go to Jakarta EE 11 (Messaging API stays 3.1). We are currently coded to EE 9 w web layer. I think the order should be
|
|
I agree with @mattrpav : jetty 12 should happen first. That's why I was holding on this PR for now. |
|
As we plan Jetty 12 for 6.3.0, I think it makes sense to upgrade to Spring 7 in this version too. |
|
Alright sounds good, we can target Spring 7 for the AMQ 6.3.0 release, that makes sense to me |
Will it be possible to say any tentative date for this AMQ 6.3.0 release which will support Spring 7, may be in terms of months like 3/6 months or more than that. It would be super helpful for us. So, that we can plan the spring upgrade accordingly. Thank you so much everyone. |
|
@sagarlatake-code track the v6.3.0 project release here: Apache ActiveMQ v6.3.0 My goal is it will be done in less than 3 months -- hopefully, by August. |
Thank you @mattrpav for the quick response and for taking the time to reply on my comment. I really appreciate your help and the effort you put into maintaining ActiveMQ. Thank you everyone for the excellent work! |
|
@jbonofre - were you going to take a look at this? i know there was some stuff to do with OSGi |
|
I think we need Spring 7.x in v6.3.0 |
Assigning it to 6.4.0 was a mistake i already fixed it |
|
We can already merge this one. OSGi is not a blocker and I will address in another PR. |
|
@jbonofre - Should we update |
Add the karaf-maven-plugin verify goal to activemq-karaf to statically validate the ActiveMQ features against the Karaf 4.4 framework, standard, spring and enterprise descriptors on every build. Verification surfaced several pre-existing feature resolution problems, now fixed: - activemq-blueprint: correct the Fragment-Host header, which targeted org.apache.activemq.activemq-osgi while the host bundle's symbolic name is org.apache.activemq.osgi, so the fragment could never attach. - activemq-amqp-client: add the netty-codec-base and netty-codec-compression bundles (packages relocated in Netty 4.2) and the jakarta.jms-api bundle required by qpid-jms-client. - activemq-shell: pull the activemq-client feature so the org.apache.activemq.console package is available. - activemq-web-console: provide the Jakarta EE 9 servlet/JSP/EL API bundles the migrated WAR imports. Spring 7: Karaf only ships Spring 6.1 features and there are no ServiceMix OSGi wrappers for Spring 7, so add spring and spring-web features that wrap the plain Spring 7 jars via the pax-url wrap protocol, and point activemq-client and activemq-web-console at them ([7,8)). Also align spring-version-range with the 7.x import range.
| <feature>war</feature> | ||
| <feature>eventadmin</feature> | ||
| <feature version="[7,8)">spring-web</feature> | ||
| <bundle dependency="true">mvn:jakarta.servlet/jakarta.servlet-api/5.0.0</bundle> |
There was a problem hiding this comment.
This should use a filtered property so it picks up the version from the parent pom.
Currently we are on 6.1.0
<dependency>
<groupId>jakarta.servlet</groupId>
<artifactId>jakarta.servlet-api</artifactId>
<version>6.1.0</version>
</dependency>
|
|
||
| <feature name="spring-web" description="Spring 7.x Web support" version="${spring-version}"> | ||
| <feature version="[7,8)">spring</feature> | ||
| <bundle dependency="true">mvn:jakarta.servlet/jakarta.servlet-api/5.0.0</bundle> |
There was a problem hiding this comment.
use filtered property for version
The karaf-maven-plugin verify goal resolves the feature bundles through pax-url from the local repository. When bound to the activemq-karaf module it fails in a clean reactor build because sibling SNAPSHOTs referenced by the features (activemq-osgi, activemq-blueprint, activemq-http and the activemq-karaf bundle itself) are not installed yet at that point in the reactor. Move the verification to activemq-karaf-itest, which is built last (after all referenced modules are installed) and already sets up the local repository for pax-url. The feature descriptors are now referenced as attached mvn: artifacts of activemq-karaf instead of local files.
4 participants
Bumps
spring-versionfrom 6.2.19 to 7.0.8.Updates
org.springframework:spring-aopfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-aop's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-beansfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-beans's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-contextfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-context's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-corefrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-core's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-expressionfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-expression's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-jmsfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-jms's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL12b44f2Avoid too many character access attempts in AntPathMatchere8f1024Ensure consistent JSP tag attribute processinga1826b7Refine JavaScriptUtils#javaScriptEscape7add524Prevent special prefixes in default view name resolution9bec52bAdd trusted packages to MappingJackson2MessageConverterUpdates
org.springframework:spring-txfrom 6.2.19 to 7.0.8Release notes
Sourced from org.springframework:spring-tx's releases.
... (truncated)
Commits
9e8cea3Release v7.0.82c18c33Track operations during SpEL expression evaluation83667f8Ensure getters have non-void return types in SpEL7a8917bImprove additional error messages in SpEL7baa865Further improve pattern caching in SpEL