PROD-2230: scope --contentIDs/--pageIDs to the workflows command - #201
Open
5PK wants to merge 1 commit into
Open
PROD-2230: scope --contentIDs/--pageIDs to the workflows command#2015PK wants to merge 1 commit into
5PK wants to merge 1 commit into
Conversation
pull/push/sync advertised --contentIDs and --pageIDs in --help but never consumed them (only lib/workflows/workflow-operation.ts reads state.explicitContentIDs/explicitPageIDs), so the flags silently had no effect there. Split them out of the shared systemArgs into a new workflowArgs object and spread it only into the workflows command builder, matching how --dryRun was previously scoped out of pull/push/sync entirely. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull/push/sync --helpadvertised--contentIDsand--pageIDs, but those commands never consumed them — onlylib/workflows/workflow-operation.tsreadsstate.explicitContentIDs/state.explicitPageIDs. Passing them to a real sync silently did nothing, which is exactly what PROD-2230 reported (the ticket's Done status was based on--dryRunbeing removed;--contentIDs/--pageIDswere left behind).contentIDs/pageIDsout of the sharedsystemArgsobject into a newworkflowArgsobject, spread only into theworkflowscommand builder — the same scoping pattern already used to remove--dryRunfrompull/push/sync.workflowsitself.Test plan
npx tsc --noEmitcleannpx jest— 105/105 suites, 1897/1897 tests passing (6 new tests added covering the new scoping; updated the tests that asserted the old shape)node dist/index.js push --help/sync --help/pull --helpno longer mention--contentIDs/--pageIDsnode dist/index.js workflows --helpstill shows both, unchanged🤖 Generated with Claude Code