fix: Package.get_purldb_entries() built a purl payload but placed it#554
Open
singlaamitesh wants to merge 1 commit into
Open
fix: Package.get_purldb_entries() built a purl payload but placed it#554singlaamitesh wants to merge 1 commit into
singlaamitesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #462
Summary
Package.get_purldb_entries() built a purl payload but placed it last in the request list, so the synchronous PurlDB tab view (which calls it with max_request_call=1) stopped after only trying hash/download_url and never attempted the purl match — even though update_from_purldb (used by 'Improve Packages from PurlDB') has no such limit and succeeds. Restructured the method to always try the purl payload as a final fallback regardless of max_request_call, since it's the broadest/cheapest match.
Changes
component_catalog/models.pycomponent_catalog/tests/test_models.pyHow this was tested
Ran
the affected testslocally.