Skip to content

chore: migrate to node 24 and use pnpm#3074

Merged
sammdec merged 19 commits into
mainfrom
chore/migrate-yarn-to-pnpm-node-24
Jul 22, 2026
Merged

chore: migrate to node 24 and use pnpm#3074
sammdec merged 19 commits into
mainfrom
chore/migrate-yarn-to-pnpm-node-24

Conversation

@sammdec

@sammdec sammdec commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrates the package manager from yarn → pnpm and bumps the build Node version from 20 → 24.

Node 20 → 24

  • .nvmrc: 20.1924 (used by actions/setup-node in all CI)
  • package.json: added "engines": { "node": "24.x" } — Vercel reads this to pick the build Node version

Yarn → pnpm

  • package.json:
    • Added "packageManager": "pnpm@9.15.9" (single source of truth; picked up by corepack + pnpm/action-setup)
    • Converted resolutionspnpm.overrides. The 3-level yarn selector tronweb/ethers/ws became ethers>ws, since pnpm overrides only support a single parent scope (matches the original intent of pinning ws under ethers)
    • Rewrote scripts and lint-staged (yarnpnpm, yarn upgrade --latestpnpm update --latest)
  • .npmrc: added node-linker=hoisted for a flat node_modules, minimizing phantom-dependency breakage during the migration
  • .husky/pre-commit: yarn i18npnpm i18n
  • CI: build & cypress composite actions + crowdin-download/crowdin-upload now add a pnpm/action-setup@v4 step, use cache: 'pnpm', and run pnpm install --frozen-lockfile. Renamed misleading YARN_COMMAND/YARN_TEST_COMMAND action inputs to COMMAND/TEST_COMMAND
  • .prettierignore: added .npmrc (no parser) and pnpm-lock.yaml (old yarn.lock was covered by *.lock)
  • Docs updated: README.md, CONTRIBUTING.md, cypress/README.md
  • Regenerated pnpm-lock.yaml (imported from yarn.lock to preserve resolved versions), removed yarn.lock

Verification

  • pnpm install succeeds and generates the lockfile
  • pnpm build completes end-to-end against the pnpm-managed dependency tree
  • pnpm lint:formatting passes

Follow-up (outside this repo)

  • Vercel dashboard: if Node.js Version is pinned in Project Settings, that overrides engines.node — set it to 24.x there too (or clear it), and confirm Node 24 is offered
  • Contributors should run nvm install 24 && nvm use to align local Node

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview, Comment Jul 22, 2026 11:08am

Request Review

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Dependency Review Summary

The full dependency review summary is too large to display here. Please download the artifact named "dependency-review-summary" to view the complete report.

View full job summary

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.32 MB (🟢 -3.37 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 95.93 KB (🟡 +59 B) 1.42 MB
/_error 1.99 KB (🟡 +1 B) 1.32 MB
/bridge 37.79 KB (🟢 -367 B) 1.36 MB
/dashboard 85.51 KB (🟡 +3 B) 1.41 MB
/faucet 15.05 KB (-1 B) 1.34 MB
/governance 89.78 KB (🟢 -294 B) 1.41 MB
/governance/ipfs-preview 102.4 KB (🟡 +618 B) 1.42 MB
/governance/v3/proposal 134.16 KB (🟡 +250 B) 1.45 MB
/history 36.33 KB (🟡 +3 B) 1.36 MB
/markets 54.81 KB (🟡 +56 B) 1.38 MB
/reserve-overview 39.86 KB (🟡 +9 B) 1.36 MB
/sgho 92.82 KB (🟢 -2.84 KB) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.32 MB (🟢 -3.37 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 95.93 KB (🟡 +59 B) 1.42 MB
/_error 1.99 KB (🟡 +1 B) 1.32 MB
/bridge 37.79 KB (🟢 -367 B) 1.36 MB
/dashboard 85.51 KB (🟡 +3 B) 1.41 MB
/faucet 15.05 KB (-1 B) 1.34 MB
/governance 89.78 KB (🟢 -294 B) 1.41 MB
/governance/ipfs-preview 102.4 KB (🟡 +618 B) 1.42 MB
/governance/v3/proposal 134.16 KB (🟡 +250 B) 1.45 MB
/history 36.33 KB (🟡 +3 B) 1.36 MB
/markets 54.81 KB (🟡 +56 B) 1.38 MB
/reserve-overview 39.86 KB (🟡 +9 B) 1.36 MB
/sgho 92.82 KB (🟢 -2.84 KB) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

mgrabina
mgrabina previously approved these changes Jul 17, 2026

@mgrabina mgrabina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid migration! just one comment

Comment thread pnpm-workspace.yaml
Comment thread pnpm-workspace.yaml Outdated
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Comment thread .github/actions/cypress/action.yml Outdated
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

AAVEV3-57

@sammdec
sammdec merged commit beed2af into main Jul 22, 2026
26 of 27 checks passed
@sammdec
sammdec deleted the chore/migrate-yarn-to-pnpm-node-24 branch July 22, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants