allow brackets in receive objects; dropped for display name#286
Open
dromer wants to merge 17 commits into
Open
allow brackets in receive objects; dropped for display name#286dromer wants to merge 17 commits into
dromer wants to merge 17 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
hvcc/compiler.py:140
- Input events are still sorted alphabetically while input parameters now preserve receiver insertion order. Since ordering tags are allowed for both params and events (and the C generator iterates receivers in insertion order), this can make event ordering inconsistent across generators/outputs that consume
ExternInfo.
# Exposed input events
in_event_list = [(k, v) for k, v in hvir.control.receivers.items() if v.extern == "event"]
in_event_list.sort(key=lambda x: x[0])
check_extern_name_conflicts("input event", in_event_list, results)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might solve #57
Needs to investigate the consequences of allowing brackets internally.