Skip to content

GUI: batch framebuffer update notifications #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moreaki wants to merge 1 commit into
base: main
Choose a base branch
from
+63 −8
Draft

GUI: batch framebuffer update notifications #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 63 additions & 8 deletions src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ class ATL_NO_VTABLE UIFrameBufferPrivate : public QObject,

/** Notifies listener about guest-screen resolution changes. */
void sigNotifyChange(int iWidth, int iHeight);
/** Notifies listener about guest-screen updates. */
void sigNotifyUpdate(int iX, int iY, int iWidth, int iHeight);
/** Notifies listener that one or more guest-screen updates are pending. */
void sigNotifyUpdatePending();
/** Notifies listener about guest-screen visible-region changes. */
void sigSetVisibleRegion(QRegion region);

Expand Down Expand Up @@ -262,6 +262,8 @@ class ATL_NO_VTABLE UIFrameBufferPrivate : public QObject,

protected slots:

/** Handles coalesced guest-screen updates. */
void sltHandlePendingNotifyUpdate();
/** Handles guest requests to change mouse pointer shape or position. */
void sltMousePointerShapeOrPositionChange();

Expand All @@ -274,6 +276,8 @@ protected slots:

/** Updates coordinate-system: */
void updateCoordinateSystem();
/** Queues a guest-screen update rectangle for asynchronous GUI-thread processing. */
void queueNotifyUpdate(ULONG uX, ULONG uY, ULONG uWidth, ULONG uHeight);

/** Default paint routine. */
void paintDefault(QPaintEvent *pEvent);
Expand Down Expand Up @@ -312,6 +316,10 @@ protected slots:
CDisplaySourceBitmap m_pendingSourceBitmap;
/** Holds whether there is a pending source bitmap which must be applied. */
bool m_fPendingSourceBitmap;
/** Holds the coalesced pending guest-screen update region. */
QRegion m_pendingUpdateRegion;
/** Holds whether a pending-update flush has already been queued. */
bool m_fNotifyUpdatePending;

/** Holds machine-view this frame-buffer is bounded to. */
UIMachineView *m_pMachineView;
Expand Down Expand Up @@ -391,6 +399,7 @@ UIFrameBufferPrivate::UIFrameBufferPrivate()
: m_uScreenId(0)
, m_iWidth(0), m_iHeight(0)
, m_fPendingSourceBitmap(false)
, m_fNotifyUpdatePending(false)
, m_pMachineView(NULL)
, m_iWinId(0)
, m_fUpdatesAllowed(false)
Expand Down Expand Up @@ -695,7 +704,7 @@ STDMETHODIMP UIFrameBufferPrivate::NotifyUpdate(ULONG uX, ULONG uY, ULONG uWidth
LogRel3(("GUI: UIFrameBufferPrivate::NotifyUpdate: Origin=%lux%lu, Size=%lux%lu, Sending to async-handler\n",
(unsigned long)uX, (unsigned long)uY,
(unsigned long)uWidth, (unsigned long)uHeight));
emit sigNotifyUpdate(uX, uY, uWidth, uHeight);
queueNotifyUpdate(uX, uY, uWidth, uHeight);

/* Unlock access to frame-buffer: */
unlock();
Expand Down Expand Up @@ -748,7 +757,7 @@ STDMETHODIMP UIFrameBufferPrivate::NotifyUpdateImage(ULONG uX, ULONG uY,
LogRel3(("GUI: UIFrameBufferPrivate::NotifyUpdateImage: Origin=%lux%lu, Size=%lux%lu, Sending to async-handler\n",
(unsigned long)uX, (unsigned long)uY,
(unsigned long)uWidth, (unsigned long)uHeight));
emit sigNotifyUpdate(uX, uY, uWidth, uHeight);
queueNotifyUpdate(uX, uY, uWidth, uHeight);
}

/* Unlock access to frame-buffer: */
Expand Down Expand Up @@ -1221,8 +1230,8 @@ void UIFrameBufferPrivate::prepareConnections()
connect(this, &UIFrameBufferPrivate::sigNotifyChange,
m_pMachineView, &UIMachineView::sltHandleNotifyChange,
Qt::QueuedConnection);
connect(this, &UIFrameBufferPrivate::sigNotifyUpdate,
m_pMachineView, &UIMachineView::sltHandleNotifyUpdate,
connect(this, &UIFrameBufferPrivate::sigNotifyUpdatePending,
this, &UIFrameBufferPrivate::sltHandlePendingNotifyUpdate,
Qt::QueuedConnection);
connect(this, &UIFrameBufferPrivate::sigSetVisibleRegion,
m_pMachineView, &UIMachineView::sltHandleSetVisibleRegion,
Expand All @@ -1240,8 +1249,8 @@ void UIFrameBufferPrivate::cleanupConnections()
/* Detach EMT connections: */
disconnect(this, &UIFrameBufferPrivate::sigNotifyChange,
m_pMachineView, &UIMachineView::sltHandleNotifyChange);
disconnect(this, &UIFrameBufferPrivate::sigNotifyUpdate,
m_pMachineView, &UIMachineView::sltHandleNotifyUpdate);
disconnect(this, &UIFrameBufferPrivate::sigNotifyUpdatePending,
this, &UIFrameBufferPrivate::sltHandlePendingNotifyUpdate);
disconnect(this, &UIFrameBufferPrivate::sigSetVisibleRegion,
m_pMachineView, &UIMachineView::sltHandleSetVisibleRegion);

Expand All @@ -1266,6 +1275,52 @@ void UIFrameBufferPrivate::updateCoordinateSystem()
m_transform = m_transform.scale(1.0 / devicePixelRatio(), 1.0 / devicePixelRatio());
}

void UIFrameBufferPrivate::queueNotifyUpdate(ULONG uX, ULONG uY, ULONG uWidth, ULONG uHeight)
{
const QRect rect((int)uX, (int)uY, (int)uWidth, (int)uHeight);
if (rect.isEmpty())
return;

m_pendingUpdateRegion |= rect;
if (!m_fNotifyUpdatePending)
{
m_fNotifyUpdatePending = true;
emit sigNotifyUpdatePending();
}
}

void UIFrameBufferPrivate::sltHandlePendingNotifyUpdate()
{
if (!m_pMachineView)
{
lock();
m_pendingUpdateRegion = QRegion();
m_fNotifyUpdatePending = false;
unlock();
return;
}

lock();

if ( m_fUnused
|| m_pendingUpdateRegion.isEmpty())
{
m_pendingUpdateRegion = QRegion();
m_fNotifyUpdatePending = false;
unlock();
return;
}

const QRegion updateRegion = m_pendingUpdateRegion;
m_pendingUpdateRegion = QRegion();
m_fNotifyUpdatePending = false;

unlock();

for (QRegion::const_iterator it = updateRegion.begin(); it != updateRegion.end(); ++it)
m_pMachineView->sltHandleNotifyUpdate(it->x(), it->y(), it->width(), it->height());
}

void UIFrameBufferPrivate::paintDefault(QPaintEvent *pEvent)
{
/* Make sure cached image is valid: */
Expand Down