DXMT: fix the supported LLVM 15 build#748
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
4550410 to
edc4e12
Compare
edc4e12 to
b9b0359
Compare
b9b0359 to
eb0e48d
Compare
|
I checked DXMT v0.80 before deciding whether this PR should instead be replaced by a vendored DXMT update. Result: v0.80 does not make this compatibility patch obsolete. It includes the separate CPU encoding heap fix from upstream DXMT, but it still has LLVM API drift in the AIR converter code:
So a future DXMT v0.80 vendor refresh may still be valuable, but it would need its own follow-up LLVM compatibility work for the newer |
|
DXMT v0.80 audit update: Updating the vendored DXMT tree to v0.80 would not currently remove the need for the source-compatibility parts of this PR. I checked DXMT v0.80 ( I opened the upstream DXMT source-compatibility issue here: 3Shain/dxmt#185 The VirtualBox
If VirtualBox later imports a DXMT version that resolves those upstream items, this PR can be reduced or replaced accordingly. |
Use llvm-config to select the packaged LLVM link library while preserving the static devtools fallback. Include the standard allocation declarations required by current Apple Clang. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
eb0e48d to
10f95a3
Compare
Summary
Fix the in-tree DXMT build against the LLVM 15 toolchain used by the supported macOS/Arm path.
The patch is deliberately limited to build/link compatibility:
llvm-configfor the LLVM libraries and library directory;llvm-config;It does not rewrite DXMT for LLVM 17 or newer APIs.
Why
Hard-coded component archive paths do not match packaged LLVM installations that expose a shared
libLLVM. Conversely, Oracle/devtools layouts may not shipllvm-config, so the existing static link remains necessary as a fallback.Validation
origin/main.git diff --checkpasses.VBoxDxMttarget build succeeds with Homebrew LLVM 15.0.7.VBoxDxMt.dylib.otool -L VBoxDxMt.dylibresolves/opt/homebrew/opt/llvm@15/lib/libLLVM.dylibwith current version 15.0.7.Refs #742.