VMSVGA: coalesce DX11 readbacks and skip unchanged updates#744
Draft
moreaki wants to merge 1 commit into
Draft
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
moreaki
marked this pull request as ready for review
July 8, 2026 08:09
moreaki
marked this pull request as draft
July 9, 2026 08:49
Merge bounded pending screen rectangles before starting a readback, copy only the dirty area for the B8G8R8X8 target, and suppress host updates when the readback bytes are unchanged. Keep the full-frame I420 conversion path unchanged. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
moreaki
force-pushed
the
agent/vmsvga-dx11-readback-coalesce
branch
from
July 16, 2026 15:58
f6e0f8d to
73d8a5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce VMSVGA DX11 screen-output readback work in three related places:
The I420 conversion/readback path remains full-frame and always reports changed output.
Scope
This is a draft performance candidate, not part of the minimal functional Retina/HiDPI enablement tracked by #742. It should remain draft—and should be closed if an isolated current-main A/B comparison does not show a repeatable benefit.
The patch intentionally keeps the existing readback-fence ordering, fixed eight-entry update queue, output-target conversion, and
vmsvgaR3UpdateScreendelivery path.Benchmark source
The validation tool is the fixed
dxmtbenchfunctional/performance harness. Performance samples are admissible only after the same run passes its browser framebuffer, guest screenshot, host presentation/signature, launch, and graphics-log gates.Validation
git diff --check: passed.origin/mainat this minimized patch tip: pending in the pinned comparison build.Earlier manual measurements covered a combined local patch stack and are not evidence for this PR.
Refs #742.